Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1609772
| From | Pablo Neira Ayuso <pablo@netfilter.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Outreachy kernel] Re: [PATCH] net: netfilter: Remove multiple assignment. |
| Date | 2017-03-27 14:30 +0200 |
| Message-ID | <tpBWy-80f-27@gated-at.bofh.it> (permalink) |
| References | <toTst-WD-3@gated-at.bofh.it> <tpBDc-7On-15@gated-at.bofh.it> <tpBWy-80f-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Mar 27, 2017 at 05:48:41PM +0530, Arushi Singhal wrote: > On Mon, Mar 27, 2017 at 5:38 PM, Pablo Neira Ayuso <pablo@netfilter.org> > wrote: > > > On Sat, Mar 25, 2017 at 06:19:47PM +0530, Arushi Singhal wrote: > > > This patch removes multiple assignments. > > > Done using coccinelle. > > > @@ > > > identifier i1,i2; > > > constant c; > > > @@ > > > - i1=i2=c; > > > + i1=c; > > > + i2=c; > > > > You have to explain why this is bad. > > > > It is against the kernel coding style and we have to avoid multiple > assignments to make the code more readable. > This error is found using Checkpatch.pl script. Then, please place this information in your patch description. Thanks!
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: netfilter: Remove multiple assignment. Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-25 14:00 +0100
Re: [PATCH] net: netfilter: Remove multiple assignment. Pablo Neira Ayuso <pablo@netfilter.org> - 2017-03-27 14:10 +0200
Re: [Outreachy kernel] Re: [PATCH] net: netfilter: Remove multiple assignment. Pablo Neira Ayuso <pablo@netfilter.org> - 2017-03-27 14:30 +0200
RE: [PATCH] net: netfilter: Remove multiple assignment. David Laight <David.Laight@ACULAB.COM> - 2017-03-27 17:20 +0200
csiph-web