Re: [PATCH v2] staging: goldfish: Fix style issues in macros

From	Frans Klaver <fransklaver@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] staging: goldfish: Fix style issues in macros
Date	2017-03-27 14:30 +0200
Message-ID	<tpBWy-80f-25@gated-at.bofh.it> (permalink)
References	<tpzBo-66r-17@gated-at.bofh.it> <tpBtw-7vp-23@gated-at.bofh.it> <tpBDc-7On-19@gated-at.bofh.it> <tpBWy-80f-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 27, 2017 at 2:13 PM, aviyae <aviyae42@gmail.com> wrote:
> I'll remove that eudyptula thing, although there are some patches that mention it
>
> (run git log --grep=eudyptula)

I haven't checked that and I think it's a shame it didn't get removed.
I don't think it adds value to the patch, as it's just for a personal
goal.

It is also custom to reply _below_ the (part of the) message you're
responding to by the way ;-).

Cheers,
Frans


> On 27/03/17 15:05, Frans Klaver wrote:
>> On Mon, Mar 27, 2017 at 1:52 PM, aviyae <aviyae42@gmail.com> wrote:
>>> From: Aviya Erenfeld <aviyae42@gmail.com>
>>>
>>> staging: goldfish: Fix style issues in macros
>>>
>>> Fix coding style issues in macros:
>>> 1. Add parenthesis around macros argument
>>> 2. Avoid arguments reuse in macros
>>>
>>> (For the eudyptula challenge)
>> How is that relevant?
>>
>> Frans
>

Thread

[PATCH] staging: goldfish: Fix coding style issues aviyae <aviyae42@gmail.com> - 2017-03-27 12:00 +0200
  Re: [PATCH] staging: goldfish: Fix coding style issues Greg KH <gregkh@linuxfoundation.org> - 2017-03-27 12:10 +0200
  [PATCH v2] staging: goldfish: Fix style issues in macros aviyae <aviyae42@gmail.com> - 2017-03-27 14:00 +0200
    Re: [PATCH v2] staging: goldfish: Fix style issues in macros Frans Klaver <fransklaver@gmail.com> - 2017-03-27 14:10 +0200
      Re: [PATCH v2] staging: goldfish: Fix style issues in macros aviyae <aviyae42@gmail.com> - 2017-03-27 14:30 +0200
        Re: [PATCH v2] staging: goldfish: Fix style issues in macros Frans Klaver <fransklaver@gmail.com> - 2017-03-27 14:30 +0200
    [PATCH v3] staging: goldfish: Fix style issues in macros aviyae <aviyae42@gmail.com> - 2017-03-27 14:30 +0200
      Re: [PATCH v3] staging: goldfish: Fix style issues in macros Greg KH <gregkh@linuxfoundation.org> - 2017-03-29 09:30 +0200
      [PATCH] staging: goldfish: Add parenthesis around macros arguments aviyae <aviyae42@gmail.com> - 2017-03-29 23:20 +0200
        Re: [PATCH] staging: goldfish: Add parenthesis around macros  arguments Greg KH <gregkh@linuxfoundation.org> - 2017-04-08 17:10 +0200
        Re: [PATCH] staging: goldfish: Add parenthesis around macros  arguments Greg KH <gregkh@linuxfoundation.org> - 2017-04-08 17:10 +0200

csiph-web