Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1609252
| From | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: Audit fixes for v4.11 (#1) |
| Date | 2017-03-25 23:30 +0100 |
| Message-ID | <tp2m5-7fQ-3@gated-at.bofh.it> (permalink) |
| References | <toF69-7By-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Mar 24, 2017 at 2:39 PM, Paul Moore <pmoore@redhat.com> wrote:
>
> This code has passed our testsuite without problem and it has held up
> to my ad-hoc stress tests (arguably better than the existing code),
> please consider pulling this as fix for the next v4.11-rcX tag.
Ok, pulled. However, looking at the changes in the patch it becomes
obvious that it is now completely bogus to inline the
"audit_signal_info()" function.
That silly inline in the header file now only generates bigger and
slower code, since that inlined function now calls another function
auditd_test_task() that is *not* inlined, so it ends up being a
function call anyway.
It would be much better to just unlinline audit_signal_info(), move it
into kernel/audit.c, and let the compiler then inline the
__audit_signal_info() helper function (or just fold it into that
function manually as part of the move).
The whole reason for that inlined part, and the uninlined
__audit_signal_info() helper was that the code *used* to be able to
avoid a function call entirely. That reason is now gone.
Linus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Audit fixes for v4.11 (#1) Paul Moore <pmoore@redhat.com> - 2017-03-24 22:40 +0100
[GIT PULL] Audit fixes for v4.11 (#1) Paul Moore <pmoore@redhat.com> - 2017-03-25 15:50 +0100
Re: Audit fixes for v4.11 (#1) Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-25 23:30 +0100
Re: Audit fixes for v4.11 (#1) Paul Moore <pmoore@redhat.com> - 2017-03-26 17:20 +0200
Re: Audit fixes for v4.11 (#1) Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-26 19:30 +0200
csiph-web