Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1609261
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Sinan Kaya <okaya@codeaurora.org> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/2] dmaengine: qcom_hidma: pause the channel on shutdown |
| Date | Sun, 26 Mar 2017 00:10:01 +0100 |
| Message-ID | <tp2YN-7Ly-5@gated-at.bofh.it> (permalink) |
| References | <tp2YN-7Ly-1@gated-at.bofh.it> |
| X-Original-To | dmaengine@vger.kernel.org, timur@codeaurora.org |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1490483053; bh=KbTrNZBrd+XbSaj0EybuEh5Co3zrYsob0nm2mXfrTzk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Os0Lar/qB2343p7JbyG2syoulOLbSGn6z2JBE31+mRAK5wV8WFLqv28LkhKCB1iu4 PzgE78YpltufTTQyCuxKmZgcRsGyND8IXYJMsrEm1lB9w3X2qPvVUBfLMAX3ovV1HO NQkYIXzcLVkaO22FlPesocGxU38shzhEIAnAeAbU= |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1490483052; bh=KbTrNZBrd+XbSaj0EybuEh5Co3zrYsob0nm2mXfrTzk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n5DYEzI6tApDxPjde/QzyxRFcmPrP8Ofhj+4aKqbb4kNQywZXbEgtB27gZm7eNNtj FjutlP37pO/qhQ9Ca9a0RULm6dMykqshnnW8nOZyHUSFXGu5LjQvlZ9zp+jEEHDiq3 kHhOsLzsusrpGReeDpz30vG2TLCIB7yWyDqqRxng= |
| Dmarc-Filter | OpenDMARC Filter v1.3.2 smtp.codeaurora.org A985860A4F |
| Authentication-Results | pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org |
| Authentication-Results | pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org |
| X-Mailer | git-send-email 1.9.1 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 46 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sinan Kaya <okaya@codeaurora.org>, Andy Gross <andy.gross@linaro.org>, David Brown <david.brown@linaro.org>, Dan Williams <dan.j.williams@intel.com>, Vinod Koul <vinod.koul@intel.com>, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Sat, 25 Mar 2017 19:04:03 -0400 |
| X-Original-Message-ID | <1490483043-4364-2-git-send-email-okaya@codeaurora.org> |
| X-Original-References | <1490483043-4364-1-git-send-email-okaya@codeaurora.org> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1609261 |
Show key headers only | View raw
We need to ensure that all DMAs and interrupts are cleared during
shutdown operation in order for kexec to start the next kernel clearly.
Otherwise, HW could be performing a DMA into random addresses in the
middle of second kernel start.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/dma/qcom/hidma.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
index 3c982c9..5072a7d 100644
--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -865,6 +865,20 @@ static int hidma_probe(struct platform_device *pdev)
return rc;
}
+static void hidma_shutdown(struct platform_device *pdev)
+{
+ struct hidma_dev *dmadev = platform_get_drvdata(pdev);
+
+ dev_info(dmadev->ddev.dev, "HI-DMA engine shutdown\n");
+
+ pm_runtime_get_sync(dmadev->ddev.dev);
+ if (hidma_ll_disable(dmadev->lldev))
+ dev_warn(dmadev->ddev.dev, "channel did not stop\n");
+ pm_runtime_mark_last_busy(dmadev->ddev.dev);
+ pm_runtime_put_autosuspend(dmadev->ddev.dev);
+
+}
+
static int hidma_remove(struct platform_device *pdev)
{
struct hidma_dev *dmadev = platform_get_drvdata(pdev);
@@ -908,6 +922,7 @@ static int hidma_remove(struct platform_device *pdev)
static struct platform_driver hidma_driver = {
.probe = hidma_probe,
.remove = hidma_remove,
+ .shutdown = hidma_shutdown,
.driver = {
.name = "hidma",
.of_match_table = hidma_match,
--
1.9.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] dmaengine: qcom_hidma: disable/enable IRQs on pause/resume Sinan Kaya <okaya@codeaurora.org> - 2017-03-26 00:10 +0100 [PATCH 2/2] dmaengine: qcom_hidma: pause the channel on shutdown Sinan Kaya <okaya@codeaurora.org> - 2017-03-26 00:10 +0100 Re: [PATCH 1/2] dmaengine: qcom_hidma: disable/enable IRQs on pause/resume Vinod Koul <vinod.koul@intel.com> - 2017-03-27 07:20 +0200
csiph-web