Re: [PATCH v2] KVM: kvm_io_bus_unregister_dev() should never fail

From	Cornelia Huck <cornelia.huck@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] KVM: kvm_io_bus_unregister_dev() should never fail
Date	2017-03-24 15:50 +0100
Message-ID	<toyHo-2WH-23@gated-at.bofh.it> (permalink)
References	<toeIG-5py-23@gated-at.bofh.it> <tohQf-7EA-35@gated-at.bofh.it> <tot51-7ku-41@gated-at.bofh.it> <toy4G-2Fu-19@gated-at.bofh.it>
Organization	IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

Show all headers | View raw

On Fri, 24 Mar 2017 07:33:01 -0300
Marcelo Tosatti <mtosatti@redhat.com> wrote:

> Still dislike the "unregister all bus devices" as that renders the guest
> unuseable. Can't you fail gracefully? Say force qemu error.

The callers are probably too varied to find a common way to do that
(multiply with different user space tools).

At least for some cases, the guest will be terminated in the near
future anyway: For example, on s390 a NULL bus will cause an error to
be propagated through KVM_RUN on the next guest->host virtio
notification, which will cause qemu to terminate the guest.

This situation is not ideal, but this is probably the most reasonable
approach.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] KVM: kvm_io_bus_unregister_dev() should never fail David Hildenbrand <david@redhat.com> - 2017-03-23 18:30 +0100
  Re: [PATCH v2] KVM: kvm_io_bus_unregister_dev() should never fail Cornelia Huck <cornelia.huck@de.ibm.com> - 2017-03-23 18:40 +0100
  Re: [PATCH v2] KVM: kvm_io_bus_unregister_dev() should never fail Marcelo Tosatti <mtosatti@redhat.com> - 2017-03-23 21:50 +0100
    Re: [PATCH v2] KVM: kvm_io_bus_unregister_dev() should never fail Dmitry Vyukov <dvyukov@google.com> - 2017-03-24 09:50 +0100
      Re: [PATCH v2] KVM: kvm_io_bus_unregister_dev() should never fail David Hildenbrand <david@redhat.com> - 2017-03-24 10:00 +0100
        Re: [PATCH v2] KVM: kvm_io_bus_unregister_dev() should never fail Cornelia Huck <cornelia.huck@de.ibm.com> - 2017-03-24 10:40 +0100
      Re: [PATCH v2] KVM: kvm_io_bus_unregister_dev() should never fail Marcelo Tosatti <mtosatti@redhat.com> - 2017-03-24 15:10 +0100
        Re: [PATCH v2] KVM: kvm_io_bus_unregister_dev() should never fail Cornelia Huck <cornelia.huck@de.ibm.com> - 2017-03-24 15:50 +0100

csiph-web