Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1608386

Re: [RFC 5/8] regulator: anatop: fix min dropout for bypass mode

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Mar 22, 2017 at 06:53:07PM +0200, Leonard Crestez wrote:

> +	if (anatop_reg->bypass)
> +		anatop_reg->rdesc.min_dropout_uV = 0;
> +	else
> +		anatop_reg->rdesc.min_dropout_uV = LDO_MIN_DROPOUT_UV;

No, this is completely broken - you can't expect to randomly change hthe
regulator description at runtime behind the back of the framework and
expect things to work.  If there is a need to do this we need an
interface for getting the current value and a way to notify of changes.

That said I would not expect the dropout voltage to be considered at
all when the regulator is bypassed, since the regulator is not
regulating it doesn't need any headroom.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RFC 5/8] regulator: anatop: fix min dropout for bypass mode Mark Brown <broonie@kernel.org> - 2017-03-24 14:00 +0100

csiph-web