Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1608227

Re: [[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as per required context

From Greg KH <greg@kroah.com>
Newsgroups linux.kernel
Subject Re: [[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as per required context
Date 2017-03-24 09:50 +0100
Message-ID <tot50-7ku-29@gated-at.bofh.it> (permalink)
References <toaOK-2Hz-37@gated-at.bofh.it> <tosVk-7gO-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 24, 2017 at 02:07:11PM +0530, Pranay Kr. Srivastava wrote:
> speakup_allocate used GFP_ATOMIC for allocations
> even while during initialization due to it's use
> in notifier call.

Is that a problem?

> Pass GFP_ flags as well to speakup_allocate depending
> on the context it is called in.

At init, we should be fine to use GFP_ATOMIC, so is this change really
needed?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH staging/speakup v3 3/3] use speakup_allocate as per required context "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2017-03-21 08:20 +0100
  Re: [PATCH staging/speakup v3 3/3] use speakup_allocate as per  required context Greg KH <gregkh@linuxfoundation.org> - 2017-03-23 14:20 +0100
    [[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as per required context "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2017-03-24 09:40 +0100
      Re: [[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as  per required context Greg KH <greg@kroah.com> - 2017-03-24 09:50 +0100
        Re: [[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as  per required context Pranay Srivastava <pranjas@gmail.com> - 2017-03-24 11:20 +0100

csiph-web