Re: [PATCH] drivers/staging/media: atomisp: Removing redundant information from dev_err

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers/staging/media: atomisp: Removing redundant information from dev_err
Date	2017-03-24 09:40 +0100
Message-ID	<tosVk-7gO-15@gated-at.bofh.it> (permalink)
References	<toqgO-5l2-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 24, 2017 at 11:18:33AM +0530, Pushkar Jambhlekar wrote:
> Removing hardcoded function name as code is already using __func__
> 
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
>  drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
> index d1a609d2..a51a27b 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
> @@ -64,7 +64,7 @@ struct hmm_buffer_object *__bo_alloc(struct kmem_cache *bo_cache)
>  
>  	bo = kmem_cache_alloc(bo_cache, GFP_KERNEL);
>  	if (!bo)
> -		dev_err(atomisp_dev, "%s: __bo_alloc failed!\n", __func__);
> +		dev_err(atomisp_dev, "%s: failed!\n", __func__);

The whole printk can be removed.  kmem_cache_alloc() has its own better
printks.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drivers/staging/media: atomisp:  Removing redundant information from dev_err Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-03-24 06:50 +0100
  Re: [PATCH] drivers/staging/media: atomisp: Removing redundant  information from dev_err Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-24 09:40 +0100

csiph-web