Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic
Date	2017-03-24 09:40 +0100
Message-ID	<tosVj-7gO-11@gated-at.bofh.it> (permalink)
References	<tnQdj-4rn-9@gated-at.bofh.it> <tnSoO-63J-25@gated-at.bofh.it> <tnSRP-6Ap-11@gated-at.bofh.it> <tnTkS-6PF-21@gated-at.bofh.it> <tnTuy-6TD-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 22 Mar 2017, Julia Cartwright wrote:
> On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote:
> > It will not be threaded because there are IRQF_ONESHOT used.
> > 
> > 	ret = devm_request_threaded_irq(&pdev->dev, irq,
> > 					sti_mbox_irq_handler,
> > 					sti_mbox_thread_handler,
> > 					IRQF_ONESHOT, mdev->name, mdev);
> 
> Indeed.  I had skipped over this important detail when I was skimming
> through the code.
> 
> Thanks for clarifying!
> 
> Is IRQF_ONESHOT really necessary for this device?  The primary handler
> invokes sti_mbox_disable_channel() on the interrupting channel, which I
> would hope would acquiesce the pending interrupt at the device-level?

Well, this is a typical case of well done split into primary and threaded
handler. There is no advantage on RT to force this into double threaded
handling. Making the lock raw is definitely the proper solution here.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RT 1/1] remoteproc: Prevent schedule while atomic Lionel Debieve <lionel.debieve@st.com> - 2017-03-22 16:20 +0100
  Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic Steven Rostedt <rostedt@goodmis.org> - 2017-03-22 17:10 +0100
    Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic Lionel DEBIEVE <lionel.debieve@st.com> - 2017-03-22 18:20 +0100
  Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic Julia Cartwright <julia@ni.com> - 2017-03-22 18:40 +0100
    Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic Steven Rostedt <rostedt@goodmis.org> - 2017-03-22 19:10 +0100
      Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic Grygorii Strashko <grygorii.strashko@ti.com> - 2017-03-22 19:40 +0100
        Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic Julia Cartwright <julia@ni.com> - 2017-03-22 19:50 +0100
          Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic Lionel DEBIEVE <lionel.debieve@st.com> - 2017-03-23 09:30 +0100
            Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic Lee Jones <lee.jones@linaro.org> - 2017-03-23 11:30 +0100
              Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic Julia Cartwright <julia@ni.com> - 2017-03-23 22:00 +0100
          Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic Thomas Gleixner <tglx@linutronix.de> - 2017-03-24 09:40 +0100

csiph-web