Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1607848
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v1 5/8] gpio: acpi: Synchronize acpi_find_gpio() and acpi_gpio_count() |
| Date | 2017-03-23 20:50 +0100 |
| Message-ID | <togUa-6WV-19@gated-at.bofh.it> (permalink) |
| References | <togU9-6WV-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
If we pass connection ID to the both functions and at the same time acpi_can_fallback_to_crs() returns false we will get different results, i.e. the number of GPIO resourses returned by acpi_gpio_count() might be not correct. Fix this by calling acpi_can_fallback_to_crs() in acpi_gpio_count() before trying to fallback. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpiolib-acpi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index e516b7a0cc50..61518273e360 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -1111,6 +1111,9 @@ int acpi_gpio_count(struct device *dev, const char *con_id) struct list_head resource_list; unsigned int crs_count = 0; + if (!acpi_can_fallback_to_crs(adev, con_id)) + return count; + INIT_LIST_HEAD(&resource_list); acpi_dev_get_resources(adev, &resource_list, acpi_find_gpio_count, &crs_count); -- 2.11.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v1 0/8] gpio: acpi: Make it working Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-23 20:50 +0100
[PATCH v1 3/8] gpio: acpi: Do sanity check for GpioInt in acpi_find_gpio() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-23 20:50 +0100
Re: [PATCH v1 3/8] gpio: acpi: Do sanity check for GpioInt in acpi_find_gpio() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-23 21:30 +0100
[PATCH v1 4/8] gpio: acpi: Even more tighten up ACPI GPIO lookups Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-23 20:50 +0100
Re: [PATCH v1 4/8] gpio: acpi: Even more tighten up ACPI GPIO lookups Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-23 21:20 +0100
Re: [PATCH v1 4/8] gpio: acpi: Even more tighten up ACPI GPIO lookups Bastien Nocera <hadess@hadess.net> - 2017-03-24 11:50 +0100
[PATCH v1 2/8] gpio: acpi: Align acpi_find_gpio() with DT version Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-23 20:50 +0100
Re: [PATCH v1 2/8] gpio: acpi: Align acpi_find_gpio() with DT version Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-23 21:20 +0100
[PATCH v1 6/8] gpio: acpi: Explain how to get GPIO descriptors in ACPI case Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-23 20:50 +0100
Re: [PATCH v1 6/8] gpio: acpi: Explain how to get GPIO descriptors in ACPI case Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-23 21:30 +0100
[PATCH v1 5/8] gpio: acpi: Synchronize acpi_find_gpio() and acpi_gpio_count() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-23 20:50 +0100
Re: [PATCH v1 5/8] gpio: acpi: Synchronize acpi_find_gpio() and acpi_gpio_count() Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-03-24 17:00 +0100
[PATCH v1 8/8] gpio: acpi: Override GPIO initialization flags Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-23 20:50 +0100
Re: [PATCH v1 0/8] gpio: acpi: Make it working Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-03-24 15:00 +0100
Re: [PATCH v1 0/8] gpio: acpi: Make it working Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-03-24 17:10 +0100
csiph-web