Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1607846

Re: [PATCH] md5: remove from lib and only live in crypto

Show all headers | View raw

On Thu, Mar 16, 2017 at 03:18:57PM +0100, Jason A. Donenfeld wrote:
> The md5_transform function is no longer used any where in the tree,
> except for the crypto api's actual implementation of md5, so we can drop
> the function from lib and put it as a static function of the crypto
> file, where it belongs. There should be no new users of md5_transform,
> anyway, since there are more modern ways of doing what it once achieved.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> In the last patch like this, we managed to get rid of halfmd4 from this
> file. In this series we get rid of md5, now that the patches have landed
> that remove such improper md5 usage from the kernel. When a final
> dependency on the (dead) sha1 is removed, then cryptohash.h will be removed
> all together. This patch is for the md5 removal.
> 

The patch itself looks good to me, and you can add
Reviewed-by: Eric Biggers <ebiggers@google.com>

There is a small issue, though, which is that currently cryptodev/master (where
this patch would be applied to) still has md5_transform() in
drivers/char/random.c, because cryptodev/master is based on v4.11-rc1 instead of
v4.11-rc2.  It's up to Herbert how he wants to deal with this, but maybe he
could merge in a later -rc.

- Eric

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] md5: remove from lib and only live in crypto "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-03-16 15:20 +0100
  Re: [PATCH] md5: remove from lib and only live in crypto "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-03-23 12:20 +0100
  Re: [PATCH] md5: remove from lib and only live in crypto Eric Biggers <ebiggers3@gmail.com> - 2017-03-23 20:50 +0100
  Re: [PATCH] md5: remove from lib and only live in crypto Herbert Xu <herbert@gondor.apana.org.au> - 2017-03-24 15:20 +0100

csiph-web