Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector
Date	2017-03-23 18:30 +0100
Message-ID	<toeIG-5py-27@gated-at.bofh.it> (permalink)
References	(1 earlier) <tj3XB-43h-25@gated-at.bofh.it> <tnehH-2Ul-5@gated-at.bofh.it> <tnSRQ-6Ap-15@gated-at.bofh.it> <tocQy-473-37@gated-at.bofh.it> <toeIG-5py-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 23, 2017 at 10:20:31AM -0700, Luck, Tony wrote:
> It can happen if Linux didn't actually take the page offline
> (because it was a kernel page). The CEC code only knows that
> it queued this page to be taken offline ... and has no way
> to know if that succeeded or not.

Right, that's the case when the offlining fails for whatever reason.

> So is it worth keeping track of the page numbers that we
> tried to offline?  If they show up again we shouldn't add
> them back into the array.

Meh, I don't like the idea of keeping an evergrowing list of PFNs we
can't do anything about anyway.

And actually, you want the kernel to keep complaining about not being
able to offline those because then admins should consider speeding up
the arrival of the maintenance window - the kernel memory itself is
going sick so that not even RAS actions help here.

I'm wondering if we should make the offlining code dump a more
comprehensible message with hints what to do...

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Thread

Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector "Luck, Tony" <tony.luck@intel.com> - 2017-03-20 23:50 +0100
  Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector Borislav Petkov <bp@alien8.de> - 2017-03-22 19:10 +0100
    Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector Borislav Petkov <bp@alien8.de> - 2017-03-23 16:30 +0100
      Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector "Luck, Tony" <tony.luck@intel.com> - 2017-03-23 18:30 +0100
        Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector Borislav Petkov <bp@alien8.de> - 2017-03-23 18:30 +0100
          Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector "Luck, Tony" <tony.luck@intel.com> - 2017-03-23 19:30 +0100
            Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector Borislav Petkov <bp@alien8.de> - 2017-03-24 12:10 +0100

csiph-web