Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1607565
| Path | csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Alban <albeu@free.fr> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/7] ath9k: Add support for reading the EEPROM data using the nvmem API |
| Date | Thu, 23 Mar 2017 15:50:01 +0100 |
| Message-ID | <tocdP-3va-13@gated-at.bofh.it> (permalink) |
| References | <tkFo6-6nZ-5@gated-at.bofh.it> <tkFo7-6nZ-39@gated-at.bofh.it> <tkI2C-8rP-3@gated-at.bofh.it> |
| X-Original-To | Christian Lamparter <chunkeey@googlemail.com> |
| X-Mailer | Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) |
| MIME-Version | 1.0 |
| Content-Type | multipart/signed; micalg=pgp-sha256; boundary="Sig_/Qa.CfbMbWyb.SYL5PtXbDRf"; protocol="application/pgp-signature" |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 78 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Alban <albeu@free.fr>, QCA ath9k Development <ath9k-devel@qca.qualcomm.com>, John Crispin <john@phrozen.org>, Kalle Valo <kvalo@codeaurora.org>, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chrisrblake93@gmail.com |
| X-Original-Date | Thu, 23 Mar 2017 15:43:28 +0100 |
| X-Original-Message-ID | <20170323154328.4bb5db44@avionic-0020> |
| X-Original-References | <1489439116-4233-1-git-send-email-albeu@free.fr> <1489439116-4233-3-git-send-email-albeu@free.fr> <1609202.bQK0rlNN3Y@debian64> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1607565 |
Show key headers only | View raw
[Multipart message — attachments visible in raw view] - view raw
On Tue, 14 Mar 2017 00:53:55 +0100
Christian Lamparter <chunkeey@googlemail.com> wrote:
> On Monday, March 13, 2017 10:05:11 PM CET Alban wrote:
> > Currently SoC platforms use a firmware request to get the EEPROM data.
> > This is mostly a hack and rely on using a user-helper scripts which is
> > deprecated. A nicer alternative is to use the nvmem API which was
> > designed for this kind of task.
> >
> > Furthermore we let CONFIG_ATH9K_AHB select CONFIG_NVMEM as such
> > devices will generally use this method for loading the EEPROM data.
> >
> > Signed-off-by: Alban <albeu@free.fr>
> > ---
> > @@ -654,6 +656,25 @@ static int ath9k_init_softc(u16 devid, struct ath_softc *sc,
> > if (ret)
> > return ret;
> >
> > + /* If the EEPROM hasn't been retrieved via firmware request
> > + * use the nvmem API insted.
> > + */
> > + if (!ah->eeprom_blob) {
> > + struct nvmem_cell *eeprom_cell;
> > +
> > + eeprom_cell = nvmem_cell_get(ah->dev, "eeprom");
> > + if (!IS_ERR(eeprom_cell)) {
> > + ah->eeprom_data = nvmem_cell_read(
> > + eeprom_cell, &ah->eeprom_size);
> > + nvmem_cell_put(eeprom_cell);
> > +
> > + if (IS_ERR(ah->eeprom_data)) {
> > + dev_err(ah->dev, "failed to read eeprom");
> > + return PTR_ERR(ah->eeprom_data);
> > + }
> > + }
> > + }
> > +
> > if (ath9k_led_active_high != -1)
> > ah->config.led_active_high = ath9k_led_active_high == 1;
> >
> Are you sure this works with AR93XX SoCs that have the calibration data
> in the OTP?
I only tested this on an ar9132 platform, so it might well be that a
few things are missing for the newer SoC. However this shouldn't break
anything existing as a platform needs to define an nvmem cell on the
athk9 device for this code to be used at all.
Alban
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH 3/7] ath9k: Add support for reading the EEPROM data using the nvmem API Alban <albeu@free.fr> - 2017-03-23 15:50 +0100 Re: [PATCH 3/7] ath9k: Add support for reading the EEPROM data using the nvmem API Christian Lamparter <chunkeey@googlemail.com> - 2017-03-24 17:30 +0100
csiph-web