Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1607523

Re: [PATCH v5] KVM: VMX: Fix enable VPID conditions

From David Hildenbrand <david@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v5] KVM: VMX: Fix enable VPID conditions
Date 2017-03-23 15:10 +0100
Message-ID <tobB8-3e8-15@gated-at.bofh.it> (permalink)
References <toac2-2e7-17@gated-at.bofh.it>
Organization Red Hat GmbH

Show all headers | View raw


> -	if (!cpu_has_vmx_vpid())
> +	if (!cpu_has_vmx_vpid() || !cpu_has_vmx_invvpid() ||
> +		!(cpu_has_vmx_invvpid_single() || cpu_has_vmx_invvpid_global()))

I still don't like this way of indentation, but looks like I am the only
one complaining :)

So I think this patch is just fine now.

>  		enable_vpid = 0;
> +
>  	if (!cpu_has_vmx_shadow_vmcs())
>  		enable_shadow_vmcs = 0;
>  	if (enable_shadow_vmcs)
> 


-- 

Thanks,

David

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v5] KVM: VMX: Fix enable VPID conditions Wanpeng Li <kernellwp@gmail.com> - 2017-03-23 13:40 +0100
  Re: [PATCH v5] KVM: VMX: Fix enable VPID conditions David Hildenbrand <david@redhat.com> - 2017-03-23 15:10 +0100
  Re: [PATCH v5] KVM: VMX: Fix enable VPID conditions Jim Mattson <jmattson@google.com> - 2017-03-23 16:40 +0100
  Re: [PATCH v5] KVM: VMX: Fix enable VPID conditions Paolo Bonzini <pbonzini@redhat.com> - 2017-03-23 19:00 +0100

csiph-web