Re: [PATCH v2] kasan: report only the first error by default

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] kasan: report only the first error by default
Date	2017-03-23 14:30 +0100
Message-ID	<toaYq-2KA-19@gated-at.bofh.it> (permalink)
References	<tnRsJ-5on-19@gated-at.bofh.it> <toalI-2iG-9@gated-at.bofh.it> <toalI-2iG-7@gated-at.bofh.it> <toaYq-2KA-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 23, 2017 at 04:06:59PM +0300, Andrey Ryabinin wrote:
> On 03/23/2017 03:41 PM, Mark Rutland wrote:

> > Rather than trying to pick an arbitrarily large number, how about we use
> > separate flags to determine whether we're in multi-shot mode, and
> > whether a (oneshot) report has been made.
> > 
> > How about the below?
>  
> Yes, it deferentially looks better.
> Can you send a patch with a changelog, or do you want me to care of it?

Would you be happy to take care of it, along with the fixup you
suggested below, as v3?

You can add my:

Signed-off-by: Mark Rutland <mark.rutland@arm.com>

Thanks,
Mark.


> >  
> > +#include <linux/bitops.h>
> >  #include <linux/ftrace.h>
> 
> We also need <linux/init.h> for __setup().
> 
> >  #include <linux/kernel.h>
> >  #include <linux/mm.h>
> > @@ -293,6 +294,40 @@ static void kasan_report_error(struct kasan_access_info *info)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] kasan: report only the first error by default Mark Rutland <mark.rutland@arm.com> - 2017-03-23 13:50 +0100
  Re: [PATCH v2] kasan: report only the first error by default Mark Rutland <mark.rutland@arm.com> - 2017-03-23 14:30 +0100

csiph-web