Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1607485

Re: [PATCH 02/11] staging: speakup: Remove multiple assignments

Show all headers | View raw

On Tue, Mar 21, 2017 at 05:12:26PM +0530, Arushi Singhal wrote:
> This patch fixes the checkpatch.pl warning "multiple assignments
> should be avoided."
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
>  drivers/staging/speakup/main.c | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index f71206878363..f8fccc8bf6b2 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -270,9 +270,12 @@ static unsigned char get_attributes(struct vc_data *vc, u16 *pos)
>  
>  static void speakup_date(struct vc_data *vc)
>  {
> -	spk_x = spk_cx = vc->vc_x;
> -	spk_y = spk_cy = vc->vc_y;
> -	spk_pos = spk_cp = vc->vc_pos;
> +	spk_x = vc->vc_x;
> +	spk_cx = spk_x;
> +	spk_y = vc->vc_y;
> +	spk_cy = spk_y;
> +	spk_pos = vc->vc_pos;
> +	spk_cp = spk_pos;

Ick, this is harder to read now, don't you think?

not good.

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESEND PATCH 00/11] staging:speakup: Multiple Checkpatch issues. Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-21 12:50 +0100
  [PATCH 09/11] staging: speakup: Simplify the NULL comparisons Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-21 12:50 +0100
    Re: [PATCH 09/11] staging: speakup: Simplify the NULL comparisons Greg KH <gregkh@linuxfoundation.org> - 2017-03-23 14:20 +0100
  [PATCH 11/11] staging: speakup: Fix alignment with parenthesis. Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-21 12:50 +0100
    Re: [PATCH 11/11] staging: speakup: Fix alignment with parenthesis. Greg KH <gregkh@linuxfoundation.org> - 2017-03-23 14:30 +0100
  [PATCH 06/11] staging: speakup: Moved OR operator to previous line. Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-21 12:50 +0100
  [PATCH 07/11] staging: speakup: spaces preferred around operator Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-21 12:50 +0100
  [PATCH 03/11] staging: speakup: Simplify "NULL" comparisons Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-21 12:50 +0100
  [PATCH 08/11] staging: speakup: Removed Unnecessary parentheses. Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-21 12:50 +0100
  [PATCH 04/11] staging: speakup: fixes braces {} should be used on all arms of this statement Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-21 12:50 +0100
  [PATCH 10/11] staging: speakup: Match alignment with open parenthesis. Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-21 12:50 +0100
  [PATCH 02/11] staging: speakup: Remove multiple assignments Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-21 12:50 +0100
    Re: [PATCH 02/11] staging: speakup: Remove multiple assignments Greg KH <gregkh@linuxfoundation.org> - 2017-03-23 14:20 +0100
  [PATCH 01/11] staging: speakup: Moved logical to previous line. Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-21 12:50 +0100
  [PATCH 05/11] staging: speakup: Remove multiple assignments Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-21 12:50 +0100
    Re: [PATCH 05/11] staging: speakup: Remove multiple assignments Greg KH <gregkh@linuxfoundation.org> - 2017-03-23 14:20 +0100
  Re: [RESEND PATCH 00/11] staging:speakup: Multiple Checkpatch issues. Greg KH <gregkh@linuxfoundation.org> - 2017-03-22 21:50 +0100

csiph-web