Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1609172

Re: [PATCH 2/7] iio: cros_ec_sensors: Fix return value to get raw and calibbias data.

Show all headers | View raw

On 24/03/17 17:44, Enric Balletbo i Serra wrote:
> The cros_ec_sensors_read function must return the type of value on all
> cases. This was always true except for RAW and CALIBBIAS data which
> returned an error or 0. This patch just fixes the mistake I introduced
> when submitting the series.
> 
> Fixes: commit c14dca07a31d (iio: cros_ec_sensors: add ChromeOS EC
> Contiguous Sensors driver)
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan
> ---
> 
>   This is another FIX, so would be interesting see it merged in this release
> cycle too. Like the above patch can be picked independently of the other
> patches and should go through IIO Jonathan's Cameron tree.
> 
>  drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
> index d6c372b..c17596f 100644
> --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
> +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
> @@ -61,7 +61,7 @@ static int cros_ec_sensors_read(struct iio_dev *indio_dev,
>  		ret = st->core.read_ec_sensors_data(indio_dev, 1 << idx, &data);
>  		if (ret < 0)
>  			break;
> -
> +		ret = IIO_VAL_INT;
>  		*val = data;
>  		break;
>  	case IIO_CHAN_INFO_CALIBBIAS:
> @@ -76,7 +76,7 @@ static int cros_ec_sensors_read(struct iio_dev *indio_dev,
>  		for (i = CROS_EC_SENSOR_X; i < CROS_EC_SENSOR_MAX_AXIS; i++)
>  			st->core.calib[i] =
>  				st->core.resp->sensor_offset.offset[i];
> -
> +		ret = IIO_VAL_INT;
>  		*val = st->core.calib[idx];
>  		break;
>  	case IIO_CHAN_INFO_SCALE:
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] mfd: cros-ec: Some fixes and improvements. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-03-24 18:50 +0100
  [PATCH 4/7] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-03-24 18:50 +0100
    Re: [PATCH 4/7] mfd: cros_ec: Get rid of cros_ec_check_features from  cros_ec_dev. Jonathan Cameron <jic23@kernel.org> - 2017-03-25 16:30 +0100
      Re: [PATCH 4/7] mfd: cros_ec: Get rid of cros_ec_check_features from  cros_ec_dev. Jonathan Cameron <jic23@kernel.org> - 2017-03-25 16:30 +0100
      Re: [PATCH 4/7] mfd: cros_ec: Get rid of cros_ec_check_features from  cros_ec_dev. Lee Jones <lee.jones@linaro.org> - 2017-03-27 14:50 +0200
  [PATCH 7/7] mfd: cros_ec: add RTC as mfd subdevice Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-03-24 18:50 +0100
  [PATCH 1/7] mfd: cros-ec: Fix host command buffer size Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-03-24 18:50 +0100
  [PATCH 6/7] rtc: cros-ec: add cros-ec-rtc driver. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-03-24 18:50 +0100
  [PATCH 5/7] mfd: cros_ec: Introduce RTC commands and events definitions. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-03-24 18:50 +0100
  [PATCH 2/7] iio: cros_ec_sensors: Fix return value to get raw and calibbias data. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-03-24 18:50 +0100
    Re: [PATCH 2/7] iio: cros_ec_sensors: Fix return value to get raw and  calibbias data. Jonathan Cameron <jic23@kernel.org> - 2017-03-25 16:10 +0100
  [PATCH 3/7] iio: cros_ec_sensors: Use devm to setup the triggered buffer. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-03-24 18:50 +0100
    Re: [PATCH 3/7] iio: cros_ec_sensors: Use devm to setup the triggered  buffer. Jonathan Cameron <jic23@kernel.org> - 2017-03-25 16:20 +0100

csiph-web