[PATCH] Staging: atomisp - octal permissions, style fix

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Derek Robson <robsonde@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] Staging: atomisp - octal permissions, style fix
Date	Sat, 25 Mar 2017 04:00:01 +0100
Message-ID	<toK5P-2HT-1@gated-at.bofh.it> (permalink)
X-Original-To	mchehab@kernel.org, gregkh@linuxfoundation.org, alan@linux.intel.com, robsonde@gmail.com, dan.carpenter@oracle.com, jeremy.lefaure@lse.epita.fr, rvarsha016@gmail.com
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=+knHba2Qn1WSpaJL/Vh0fzsQZC/OWvwIZ44GEHH27Qw=; b=TrNK0fQhagJAytS+foSpoo3ym4UkToyY/rzJfPrGEgNxggKxaCBvM3BP4PjeGYuGQo A/wn4c7X+ijzv6YOmjBi1RNfngDShzzTnL0y6MOl71maNl/3Fnd/zxWKFcXTEPE+PFcj kYNljofqvk+ecUEmQED7A+36UmAuw8+y4H9T3IizPxwv2NDIyLNEtdMoxDLEDABz/cDW ULNILDOWJcEs9C6rfgk1xAq6rkpgb1kgEIhja4QmVRlGu4eG6GqLaSBq2nQn1RGB1DJr RM41JxruiVfAYZYtgR3BJzICQYbhHd5Ar8AtDAZaAci1DrXG3I6uDuSV4AZruMCoBcjX fDoA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+knHba2Qn1WSpaJL/Vh0fzsQZC/OWvwIZ44GEHH27Qw=; b=MQXMAHPEiclxCkJXTX/VWd8q3rLWCvqka1DwV71BIwCL+IEl82EZmUt1k+8ktL9ebj vVSds/mNuqhvsbCNMwCwGWFsojaIuO+iyR+hHSIECWiyU8mQCfUXeJJhKwITlUHoHXH6 pnQtyqN3Vnggv2eBrvaYS466a2tS7bOl9WWVD1aIkZ4jktxm9LxF/zXwSV5ezoBVLFf4 lEgmqDnMr72ivcS77iFidv9B5/k05jbc4QR2zyezgkWRjM83OoSWJ/NiMwLk92Ff0IiH uk7lOh+3Mf+BrPov1M61fFlwXnZ8slsSZ6GYXey0ZTylGi4IZb2JM4OnMAN9nuhTHaqX p07Q==
X-Gm-Message-State	AFeK/H1Q/PdBaONm+JFxyle358LX+DBUgjfYOy6ahoRu631pb+SVRmWWG6aEnOxb3b7KMw==
X-Received	by 10.98.218.10 with SMTP id c10mr12671075pfh.240.1490410545771; Fri, 24 Mar 2017 19:55:45 -0700 (PDT)
X-Mailer	git-send-email 2.12.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
X-Original-Cc	linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 25 Mar 2017 15:55:32 +1300
X-Original-Message-ID	<20170325025532.20685-1-robsonde@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1609069

Show key headers only | View raw

Changed permissions to octal style
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
---
 drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c | 9 +++------
 drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c       | 8 ++++----
 2 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c
index fcfe8d7190b0..763bc5f2a033 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c
@@ -163,12 +163,9 @@ static ssize_t iunit_dbgopt_store(struct device_driver *drv, const char *buf,
 }
 
 static struct driver_attribute iunit_drvfs_attrs[] = {
-	__ATTR(dbglvl, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH, iunit_dbglvl_show,
-		iunit_dbglvl_store),
-	__ATTR(dbgfun, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH, iunit_dbgfun_show,
-		iunit_dbgfun_store),
-	__ATTR(dbgopt, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH, iunit_dbgopt_show,
-		iunit_dbgopt_store),
+	__ATTR(dbglvl, 0644, iunit_dbglvl_show, iunit_dbglvl_store),
+	__ATTR(dbgfun, 0644, iunit_dbgfun_show, iunit_dbgfun_store),
+	__ATTR(dbgopt, 0644, iunit_dbgopt_show, iunit_dbgopt_store),
 };
 
 static int iunit_drvfs_create_files(struct pci_driver *drv)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
index a362b492ec8e..edf554e8e96e 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
@@ -161,10 +161,10 @@ static ssize_t dynamic_pool_show(struct device *dev,
 	return ret;
 };
 
-static DEVICE_ATTR(active_bo, S_IRUGO, active_bo_show, NULL);
-static DEVICE_ATTR(free_bo, S_IRUGO, free_bo_show, NULL);
-static DEVICE_ATTR(reserved_pool, S_IRUGO, reserved_pool_show, NULL);
-static DEVICE_ATTR(dynamic_pool, S_IRUGO, dynamic_pool_show, NULL);
+static DEVICE_ATTR(active_bo, 0444, active_bo_show, NULL);
+static DEVICE_ATTR(free_bo, 0444, free_bo_show, NULL);
+static DEVICE_ATTR(reserved_pool, 0444, reserved_pool_show, NULL);
+static DEVICE_ATTR(dynamic_pool, 0444, dynamic_pool_show, NULL);
 
 static struct attribute *sysfs_attrs_ctrl[] = {
 	&dev_attr_active_bo.attr,
-- 
2.12.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] Staging: atomisp - octal permissions, style fix Derek Robson <robsonde@gmail.com> - 2017-03-25 04:00 +0100

csiph-web