Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1608928

Re: [PATCH v2] net: stmmac: add set_mac to the stmmac_ops

Show all headers | View raw

From: Corentin Labbe <clabbe.montjoie@gmail.com>
Date: Thu, 23 Mar 2017 14:40:22 +0100

> Two different set_mac functions exists but stmmac_dwmac4_set_mac() is
> only used for enabling and never for disabling.
> So on dwmac4, the MAC RX/TX is never disabled.
> 
> This patch add a generic function pointer set_mac() to stmmac_ops and
> replace all call to stmmac_set_mac/stmmac_dwmac4_set_mac by a call to
> this pointer.
> 
> Since dwmac4_ops is const, set_mac cannot be modified after, and so dwmac4_ops
> is duplioacted like dwmac4_dma_ops.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] net: stmmac: add set_mac to the stmmac_ops Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-03-23 14:50 +0100
  Re: [PATCH v2] net: stmmac: add set_mac to the stmmac_ops David Miller <davem@davemloft.net> - 2017-03-24 20:40 +0100

csiph-web