Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1608892

[PATCH] timekeeping: no conversion to bool needed

Show all headers | View raw

As interp_forward is type bool assignment to a logical operation directly
is sufficient here.

Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---

Found by coccinelle: boolconv.cocci
./kernel/time/timekeeping.c:1000:9-14: WARNING: conversion to bool not needed he
re
The explicit conversion to bool is not needed here as the logical operator
ensures that the right-side is a bool anyway.

Patch was compiletested with: x86_64_defconfig

Patch is against 4.11-rc3 (localversion-next is next-20170324)

 kernel/time/timekeeping.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 5b63a21..2921469 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -992,16 +992,15 @@ static int adjust_historical_crosststamp(struct system_time_snapshot *history,
 	bool interp_forward;
 	int ret;
 
 	if (total_history_cycles == 0 || partial_history_cycles == 0)
 		return 0;
 
 	/* Interpolate shortest distance from beginning or end of history */
-	interp_forward = partial_history_cycles > total_history_cycles/2 ?
-		true : false;
+	interp_forward = partial_history_cycles > total_history_cycles / 2;
 	partial_history_cycles = interp_forward ?
 		total_history_cycles - partial_history_cycles :
 		partial_history_cycles;
 
 	/*
 	 * Scale the monotonic raw time delta by:
 	 *	partial_history_cycles / total_history_cycles
-- 
2.1.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] timekeeping: no conversion to bool needed Nicholas Mc Guire <der.herr@hofr.at> - 2017-03-24 20:10 +0100

csiph-web