Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1608790

Re: [PATCH] acpi: fix incompatibility with mcount-based function graph tracing

Show all headers | View raw

On Tue, Mar 21, 2017 at 09:44:03PM +0100, Paul Menzel wrote:
> I checked out Linux 4.9.16, applied your patch on top, and copied the Debian
> 4.9 Linux kernel configuration, did `make menuconfig`, disabled building
> debugging symbols, and executed `ARCH=i386 make -j40 deb-pkg`.
> 
> I installed that package on the Lenovo X60, and the result with tracing
> enabled has improved. The system suspends without a crash. Unfortunately,
> instead of resuming when pressing the power button, it starts from scratch.
> Suspend and resume without tracing enabled works though.
> 
> I’ll try to collect logs, but I don’t know, if there will be any, if the
> system just resets.
> 
> Maybe, this can be reproduced in QEMU?

So I was able to recreate this issue in qemu, and after some hours of
debugging I managed to figure it out.

It's rebooting during the resume because of a triple fault in
prepare_ftrace_return().

acpi wakeup for secondary cpu
  startup_32_smp()
    load_ucode_ap()
      prepare_ftrace_return()
        ftrace_graph_is_dead()
	  dereferences virtual address (kill_ftrace_graph) in real mode <-- BOOM

I tried fixing it by changing load_ucode_ap() to notrace, but that
function calls some other functions which also have mcount hooks, which
call other functions, etc.

Instead I was able to "fix" it by ignoring ftrace calls in real mode:

-----
index 8f3d9cf..5c0d0c6 100644
--- a/arch/x86/kernel/ftrace.c
+++ b/arch/x86/kernel/ftrace.c
@@ -983,6 +983,9 @@ void prepare_ftrace_return(unsigned long self_addr, unsigned long *parent,
 	unsigned long return_hooker = (unsigned long)
 				&return_to_handler;
 
+	if (__builtin_return_address(0) < TASK_SIZE_MAX)
+		return;
+
 	if (unlikely(ftrace_graph_is_dead()))
 		return;
---------------

I'm not sure what the best fix should really be.  A few ideas off the
top of my head:

- A real mode check similar to the above (except it should probably be
  more precise)

- Make tracing_graph_pause a percpu variable so that it can be read from
  prepare_ftrace_return()

- pause_graph_tracing() from ftrace_suspend_notifier_call()

Steven, thoughts?

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] acpi: fix incompatibility with mcount-based function graph tracing Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-16 15:30 +0100
  Re: [PATCH] acpi: fix incompatibility with mcount-based function  graph tracing Steven Rostedt <rostedt@goodmis.org> - 2017-03-16 15:50 +0100
  Re: [PATCH] acpi: fix incompatibility with mcount-based function  graph tracing Paul Menzel <pmenzel@molgen.mpg.de> - 2017-03-21 21:50 +0100
    Re: [PATCH] acpi: fix incompatibility with mcount-based function  graph tracing Paul Menzel <pmenzel@molgen.mpg.de> - 2017-03-22 01:10 +0100
    Re: [PATCH] acpi: fix incompatibility with mcount-based function  graph tracing Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-24 19:20 +0100
      Re: [PATCH] acpi: fix incompatibility with mcount-based function  graph tracing Steven Rostedt <rostedt@goodmis.org> - 2017-03-24 19:50 +0100
        Re: [PATCH] acpi: fix incompatibility with mcount-based function graph tracing "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-25 14:30 +0100
          Re: [PATCH] acpi: fix incompatibility with mcount-based function  graph tracing Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-27 16:20 +0200
            [PATCH] ftrace/x86: fix x86-32 triple fault with graph tracing and  suspend-to-ram Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-27 17:00 +0200
              Re: [PATCH] ftrace/x86: fix x86-32 triple fault with graph tracing  and suspend-to-ram Paul Menzel <pmenzel@molgen.mpg.de> - 2017-03-27 17:10 +0200
                Re: [PATCH] ftrace/x86: fix x86-32 triple fault with graph tracing  and suspend-to-ram Steven Rostedt <rostedt@goodmis.org> - 2017-03-27 17:30 +0200
                [PATCH v2] ftrace/x86: fix x86-32 triple fault with graph tracing  and suspend-to-ram Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-27 17:30 +0200
            Re: [PATCH] acpi: fix incompatibility with mcount-based function graph tracing "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-27 19:10 +0200

csiph-web