Re: [PATCH] arm64: kconfig: allow support for memory failure handling

Path	csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	"Baicar, Tyler" <tbaicar@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm64: kconfig: allow support for memory failure handling
Date	Fri, 24 Mar 2017 17:40:01 +0100
Message-ID	<toApP-4fB-13@gated-at.bofh.it> (permalink)
References	<t6aNb-37z-7@gated-at.bofh.it> <toc4a-3pL-21@gated-at.bofh.it> <toApP-4fB-15@gated-at.bofh.it>
X-Original-To	Punit Agrawal <punit.agrawal@arm.com>, James Morse <james.morse@arm.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1490373379; bh=kVTDAGeOmQ/ikS/Aw5eVSgK1rkXYpy3MnU6Sxw/cXaM=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=EcNxFqlWlk59wBMKWvLuRU5D/4khrGdVAsMzWcjYWoOsWy2pgNlLyAz7mYoB3w3GG OTPfeloMSipEUBQ2q+hQueQ+TDTUGEHzb39s7aU2C5sciMAXFdtOLSBT7i/O8wbuF1 wI2cG8PJmM6aRi+YRQejDc6lDc6KMuf23u860jyo=
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1490373378; bh=kVTDAGeOmQ/ikS/Aw5eVSgK1rkXYpy3MnU6Sxw/cXaM=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=UeIepv3fieQz/luNwd3HzaJdrOnEeCCrXPE/CyNczA04zOVfpnHDB0cnjMUrCrF81 BRzq2vq2J1zC73pv7KRYvyyvdWdCf23hyWlBMayw9N+cce8a+C/J7vFbi75AHsai3s tnV/YHQVd/D+nCgWF03nnoCQ4Rn1qgr2aZBYFJA4=
Dmarc-Filter	OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5B2886031A
Authentication-Results	pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org
Authentication-Results	pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org
User-Agent	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	80
Organization	linux.* mail to news gateway
X-Original-Cc	catalin.marinas@arm.com, will.deacon@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
X-Original-Date	Fri, 24 Mar 2017 10:36:16 -0600
X-Original-Message-ID	<c76008af-4061-f44c-5643-77070406364e@codeaurora.org>
X-Original-References	<1485985115-27274-1-git-send-email-tbaicar@codeaurora.org> <58D3DCA1.5090006@arm.com> <1dc99ff7-65ac-4858-6008-8ee8d0f6f336@arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1608657

Show key headers only | View raw

On 3/23/2017 10:12 AM, Punit Agrawal wrote:
>
>
> On 23/03/17 14:33, James Morse wrote:
>> Hi Punit,
>>
>> On 01/02/17 21:38, Tyler Baicar wrote:
>>> From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
>>>
>>> If ACPI_APEI and MEMORY_FAILURE is configured, select
>>> ACPI_APEI_MEMORY_FAILURE. This enables memory failure recovery
>>> when such memory failure is reported through ACPI APEI. APEI
>>> (ACPI Platform Error Interfaces) provides a means for the
>>> platform to convey error information to the kernel.
>>>
>>> Declare ARCH_SUPPORTS_MEMORY_FAILURE, as arm64 does support
>>> memory failure recovery attempt.
>>
>> Am I right in thinking we should wait for the hugepage issue you 
>> found with
>> hwpoison [0] to be fixed before arm64 can have 
>> ARCH_SUPPORTS_MEMORY_FAILURE?
>
> We should at the least fix the huge_pte_offset() issue discovered in [0]
> before we enable memory failure handling. Earlier today I posted a
> RFC[1] fix for it based on Catalin's suggestion.
>
>>
>> (If so, can this patch become part of that series to they are 
>> obviously related!)
>
> Good point - I can include the patches enabling memory failure handling
> on ARM64 if Tyler's fine with it.
That's fine with me!

Thanks,
Tyler
>
> Thanks,
> Punit
>
> [1] https://lkml.org/lkml/2017/3/23/293
>
>>
>> Thanks,
>>
>> James
>>
>> [0] https://www.spinics.net/lists/arm-kernel/msg568995.html
>>
>>
>>
>>
>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>>> index f92778d..4cd12a0 100644
>>> --- a/arch/arm64/Kconfig
>>> +++ b/arch/arm64/Kconfig
>>> @@ -15,6 +15,8 @@ config ARM64
>>>      select ARCH_HAS_SG_CHAIN
>>>      select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
>>>      select ARCH_USE_CMPXCHG_LOCKREF
>>> +    select ACPI_APEI_MEMORY_FAILURE if ACPI_APEI && MEMORY_FAILURE
>>> +    select ARCH_SUPPORTS_MEMORY_FAILURE
>>>      select ARCH_SUPPORTS_ATOMIC_RMW
>>>      select ARCH_SUPPORTS_NUMA_BALANCING
>>>      select ARCH_WANT_COMPAT_IPC_PARSE_VERSION
>>>
>>
>>
>>
> IMPORTANT NOTICE: The contents of this email and any attachments are 
> confidential and may also be privileged. If you are not the intended 
> recipient, please notify the sender immediately and do not disclose 
> the contents to any other person, use it for any purpose, or store or 
> copy the information in any medium. Thank you.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] arm64: kconfig: allow support for memory failure handling James Morse <james.morse@arm.com> - 2017-03-23 15:40 +0100
  Re: [PATCH] arm64: kconfig: allow support for memory failure handling "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-03-24 17:40 +0100

csiph-web