Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1608641

Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, 2017-03-24 at 17:13 +0100, Arnd Bergmann wrote:
> 
> I'd still prefer this to be a whitelist of the existing architectures using PCI
> MMAP in procfs, there is really no reason for arm64 to be special, the
> one thing we want to control here is whether new architectures (including
> arm64) that have never had either the sysfs or the procfs interface
> should get one or both of them.
>
> As it seems that there are important use cases for the sysfs interface
> and your patch series will just make that work everywhere, I'd argue
> that we should just always provide the sysfs interface now, and use
> HAVE_PCI_MMAP only control the procfs interface.

I still have no sympathy for the "we don't want <this> tiny part of the
legacy generic non-architecture-specific procfs ABI to exist on ARM64".
Why not just kill /proc/bus/pci *entirely* there?

But sure, I suppose we could refactor things so that the sysfs mmap
bits depend on (HAVE_PCI_MMAP || ARCH_GENERIC_MMAP_RESOURCE_RANGE)
rather than having architectures define the latter in *addition* to the
former.

> That way, we turn on the sysfs interface on arc, arm64, frv and tile
> as well as any future architecture with PCI support, but leave
> the procfs support as opt-in.

OK. My plan was for ARCH_GENERIC_MMAP_RESOURCE_RANGE to go away once
all architectures were converted, and HAVE_PCI_MMAP to be all that's
left. It does make send to do arc, fr-v and tile too though. So we can
do it that way.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/17] PCI resource mmap cleanup David Woodhouse <dwmw2@infradead.org> - 2017-03-22 14:40 +0100
  [PATCH 04/17] pci: Add arch_can_pci_mmap_wc() macro David Woodhouse <dwmw2@infradead.org> - 2017-03-22 14:40 +0100
  [PATCH 15/17] sh: Use generic pci_mmap_resource_range() David Woodhouse <dwmw2@infradead.org> - 2017-03-22 14:40 +0100
  [PATCH 10/17] arm: Use generic pci_mmap_resource_range() David Woodhouse <dwmw2@infradead.org> - 2017-03-22 14:40 +0100
  [PATCH 17/17] arm64: Do not expose PCI mmap through procfs David Woodhouse <dwmw2@infradead.org> - 2017-03-22 14:40 +0100
    Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs Sinan Kaya <okaya@codeaurora.org> - 2017-03-22 15:00 +0100
      Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs David Woodhouse <dwmw2@infradead.org> - 2017-03-22 15:10 +0100
        Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs Will Deacon <will.deacon@arm.com> - 2017-03-22 15:20 +0100
          Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs Sinan Kaya <okaya@codeaurora.org> - 2017-03-22 16:50 +0100
        Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs Sinan Kaya <okaya@codeaurora.org> - 2017-03-22 15:20 +0100
    Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs Arnd Bergmann <arnd@arndb.de> - 2017-03-24 17:20 +0100
      Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs Arnd Bergmann <arnd@arndb.de> - 2017-03-24 17:20 +0100
        Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs David Woodhouse <dwmw2@infradead.org> - 2017-03-24 17:30 +0100
      Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs David Woodhouse <dwmw2@infradead.org> - 2017-03-24 17:30 +0100
  [PATCH 18/17] x86: Use generic pci_mmap_resource_range() David Woodhouse <dwmw2@infradead.org> - 2017-03-23 15:30 +0100
  Re: [PATCH 00/17] PCI resource mmap cleanup David Woodhouse <dwmw2@infradead.org> - 2017-03-24 12:50 +0100
    Re: [PATCH 00/17] PCI resource mmap cleanup "Luck, Tony" <tony.luck@intel.com> - 2017-03-24 18:00 +0100
  Re: [PATCH 00/17] PCI resource mmap cleanup Arnd Bergmann <arnd@arndb.de> - 2017-03-24 17:30 +0100

csiph-web