Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

From	Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver
Date	2017-03-24 18:10 +0100
Message-ID	<toASR-4Ki-1@gated-at.bofh.it> (permalink)
References	<toyo1-2Pm-3@gated-at.bofh.it> <toA6t-48t-7@gated-at.bofh.it> <toAgb-4c4-33@gated-at.bofh.it> <toAzx-4jh-29@gated-at.bofh.it> <toAzx-4jh-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 24, 2017 at 05:45:41PM +0100, Bartlomiej Zolnierkiewicz wrote:
> > > > And I think the probe might be called twice, for example in case of
> > > > mistake in DTB.
> > > 
> > > Even if this is possible resource allocation code in the driver will
> > > take take care of handling it just fine,
> > 
> > Indeed, the devm_ioremap_resource() solves the case. I can drop the
> > check then.
> 
> Looking on this a bit more it seems that devm_ioremap_resource() will
> not cover all mistakes (using compatible by mistake in some other DTB
> node).
> 
> Leave the check, I take my objection back.

Great! Thanks for feedback.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-24 15:30 +0100
  Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-24 15:40 +0100
    Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-24 15:50 +0100
      Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-24 16:00 +0100
      Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-24 16:00 +0100
      Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-24 16:00 +0100
    Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-24 15:50 +0100
  Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-24 16:30 +0100
    Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-24 16:50 +0100
      Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-24 17:20 +0100
        Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-24 17:30 +0100
          Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-24 17:50 +0100
            Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-24 18:10 +0100

csiph-web