Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1607334

Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support

Show all headers | View raw

On Thu, 23 Mar 2017 11:11:09 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Mon, Mar 20, 2017 at 2:51 PM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
> > On Fri, Mar 17, 2017 at 10:17:47AM +0100, Ralph Sennhauser wrote:  
> >> On Thu, 16 Mar 2017 17:03:05 +0100
> >> Linus Walleij <linus.walleij@linaro.org> wrote:  
> > [...]  
> >> > > +static void mvebu_pwm_suspend(struct mvebu_gpio_chip *mvchip)
> >> > > +static void mvebu_pwm_resume(struct mvebu_gpio_chip *mvchip)  
> >> >
> >> > I think both of these need to be tagged __maybe_unused to not
> >> > give noise in randconfig builds.  
> >>
> >> I haven't seen any warnings with CONFIG_PWM disabled. Which
> >> configuration you expect to trigger a warning? mvebu_pwm_probe
> >> should be the same, right?  
> >
> > It's got nothing to do with CONFIG_PWM and as far as I can tell your
> > usage of IS_ENABLED() is fine here. However, if you try building the
> > driver with a !PM configuration, both *_suspend() and *_resume() end
> > up being unused and giving you a warning.  
> 
> Yes I was referring to the !PM case.

Only this time around I did read !PM not as !PWM and so it became clear
what you meant the first time around and why __maybe_unused is required.

Thanks
Ralph

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] gpio: mvebu: Add PWM fan support Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-16 07:50 +0100
  [PATCH 3/4] ARM: mvebu: Enable SENSORS_PWM_FAN in defconfig Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-16 07:50 +0100
  [PATCH 1/4] gpio: mvebu: Add limited PWM support Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-16 07:50 +0100
    Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support Linus Walleij <linus.walleij@linaro.org> - 2017-03-16 17:10 +0100
      Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-17 10:20 +0100
        Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support Thierry Reding <thierry.reding@gmail.com> - 2017-03-20 15:00 +0100
          Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-21 07:40 +0100
          Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support Linus Walleij <linus.walleij@linaro.org> - 2017-03-23 11:20 +0100
            Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-23 11:40 +0100
      Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support Andrew Lunn <andrew@lunn.ch> - 2017-03-18 16:40 +0100
        Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support Thierry Reding <thierry.reding@gmail.com> - 2017-03-20 15:00 +0100
      Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support Thierry Reding <thierry.reding@gmail.com> - 2017-03-20 15:50 +0100
    Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support Thierry Reding <thierry.reding@gmail.com> - 2017-03-20 14:50 +0100
      Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-21 07:40 +0100
        Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support Andrew Lunn <andrew@lunn.ch> - 2017-03-21 16:00 +0100
  Re: [PATCH 0/4] gpio: mvebu: Add PWM fan support Linus Walleij <linus.walleij@linaro.org> - 2017-03-16 16:50 +0100
  Re: [PATCH 0/4] gpio: mvebu: Add PWM fan support Andrew Lunn <andrew@lunn.ch> - 2017-03-18 16:40 +0100
    Re: [PATCH 0/4] gpio: mvebu: Add PWM fan support Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-18 17:20 +0100

csiph-web