Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

From	Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Newsgroups	linux.kernel
Subject	Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"
Date	2017-03-23 12:00 +0100
Message-ID	<to8Df-14F-3@gated-at.bofh.it> (permalink)
References	<to7QR-Io-9@gated-at.bofh.it> <to80y-ML-13@gated-at.bofh.it> <to8ae-TC-35@gated-at.bofh.it> <to8tz-116-21@gated-at.bofh.it> <to8tz-116-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 3/23/2017 11:48 AM, Giuseppe CAVALLARO wrote:
> Hello
>
> On 3/23/2017 11:20 AM, Corentin Labbe wrote:
>>> I have a 4.21 QoS Core with 4 RX + 4 TX and detected no regression.
>>> >Could you please share the iperf cmds you are using in order for me 
>>> to reproduce
>>> >in my side?
>
> Joao, you have a really powerful HW integration with multiple channels 
> for both RX and TX.
> Often this is not the same for other setup where, usually just a DMA0 
> is present or, sometime, there
> is just one RX extra channel.
>
> My question is, what happens on this kind of configurations? Are we 
> still guarantying the best performances?
>
> Also we have to guarantee, that the TSO and SG are always working. 
> Another point is the buffer sizes that
> can be different among platforms.
>
> The problem  below reported by Corentin push me to think that there is 
> a bug, so we should
> understand when this has been introduced and if likely fixed by some 
> configuration we are
> not take care right now.
>
> ndesc_get_rx_status: Oversized frame spanned multiple buffers"

I wonder if this could be easily triggered by getting a big file via 
FTP. So not properly related on performance benchs

peppe

>
>
> Best Regards
> Peppe
>

Thread

stmmac: Performance regression after commit aff3d9eff843 "net:  stmmac: enable multiple buffers" Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-03-23 11:10 +0100
  Re: stmmac: Performance regression after commit aff3d9eff843 "net:  stmmac: enable multiple buffers" Joao Pinto <Joao.Pinto@synopsys.com> - 2017-03-23 11:20 +0100
    Re: stmmac: Performance regression after commit aff3d9eff843 "net:  stmmac: enable multiple buffers" Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-03-23 11:30 +0100
      Re: stmmac: Performance regression after commit aff3d9eff843 "net:  stmmac: enable multiple buffers" Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-03-23 11:50 +0100
        Re: stmmac: Performance regression after commit aff3d9eff843 "net:  stmmac: enable multiple buffers" Joao Pinto <Joao.Pinto@synopsys.com> - 2017-03-23 12:00 +0100
          Re: stmmac: Performance regression after commit aff3d9eff843 "net:  stmmac: enable multiple buffers" Joao Pinto <Joao.Pinto@synopsys.com> - 2017-03-23 14:00 +0100
        Re: stmmac: Performance regression after commit aff3d9eff843 "net:  stmmac: enable multiple buffers" Joao Pinto <Joao.Pinto@synopsys.com> - 2017-03-23 12:00 +0100
        Re: stmmac: Performance regression after commit aff3d9eff843 "net:  stmmac: enable multiple buffers" Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-03-23 12:00 +0100
      Re: stmmac: Performance regression after commit aff3d9eff843 "net:  stmmac: enable multiple buffers" Joao Pinto <Joao.Pinto@synopsys.com> - 2017-03-23 11:50 +0100

csiph-web