Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1607359
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 2/3] mfd: arizona: Display register addresses in hex |
| Date | 2017-03-23 12:00 +0100 |
| Message-ID | <to8Df-14F-11@gated-at.bofh.it> (permalink) |
| References | <tliz7-Cf-1@gated-at.bofh.it> <tliz8-Cf-35@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 15 Mar 2017, Charles Keepax wrote:
> Register addresses are normally displayed in hex throughout the Arizona
> driver. Update the arizona_poll_reg function to follow this convention.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>
> No changes since v4.
>
> drivers/mfd/arizona-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index e00f577..4cb34c3 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -245,7 +245,7 @@ static int arizona_poll_reg(struct arizona *arizona,
> for (i = 0; i < timeout; i++) {
> ret = regmap_read(arizona->regmap, reg, &val);
> if (ret != 0) {
> - dev_err(arizona->dev, "Failed to read reg %u: %d\n",
> + dev_err(arizona->dev, "Failed to read reg 0x%x: %d\n",
> reg, ret);
> continue;
> }
> @@ -256,7 +256,7 @@ static int arizona_poll_reg(struct arizona *arizona,
> usleep_range(1000, 5000);
> }
>
> - dev_err(arizona->dev, "Polling reg %u timed out: %x\n", reg, val);
> + dev_err(arizona->dev, "Polling reg 0x%x timed out: %x\n", reg, val);
> return -ETIMEDOUT;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 1/3] mfd: arizona: Remove duplicate set of ret variable Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-03-15 16:00 +0100
[PATCH v4 3/3] mfd: arizona: Refactor arizona_poll_reg Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-03-15 16:00 +0100
Re: [PATCH v4 3/3] mfd: arizona: Refactor arizona_poll_reg Lee Jones <lee.jones@linaro.org> - 2017-03-23 12:00 +0100
[PATCH v4 2/3] mfd: arizona: Display register addresses in hex Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-03-15 16:00 +0100
Re: [PATCH v4 2/3] mfd: arizona: Display register addresses in hex Lee Jones <lee.jones@linaro.org> - 2017-03-23 12:00 +0100
Re: [PATCH v4 1/3] mfd: arizona: Remove duplicate set of ret variable Lee Jones <lee.jones@linaro.org> - 2017-03-23 12:00 +0100
csiph-web