Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1607307

Re: [PATCH v2 4/4] pinctrl: samsung: Use devres version of gpiochip_add_data

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 4/4] pinctrl: samsung: Use devres version of gpiochip_add_data
Date 2017-03-23 10:50 +0100
Message-ID <to7xw-mT-9@gated-at.bofh.it> (permalink)
References <tbuid-6G9-3@gated-at.bofh.it> <tbuie-6G9-7@gated-at.bofh.it> <tbQVs-4RP-23@gated-at.bofh.it> <tbReO-4Z1-7@gated-at.bofh.it> <tnaxt-nq-45@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Mar 20, 2017 at 7:44 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Fri, Feb 17, 2017 at 01:52:14PM +0000, Charles Keepax wrote:
>> On Fri, Feb 17, 2017 at 03:35:04PM +0200, Krzysztof Kozlowski wrote:
>> > On Thu, Feb 16, 2017 at 01:27:16PM +0000, Charles Keepax wrote:
>> > > Use devm_gpiochip_add_data to simplify the error path in
>> > > samsung_gpiolib_register. Additionally this would also fix a leak if
>> > > the pinctrl driver was unbound, although admittedly I can't see any
>> > > good use-case for doing so, but the driver does currently allow it.
>> >
>> > Driver does not allow unbinding (.suppress_bind_attrs = true)...
>> >
>>
>> Oops... sorry missed that.
>
> Can you resend with updated commit msg? I think it was not picked up by
> Linus yet.

I'm expecting you to pick it up and send to me by pull request now I guess,
or did we agree that a Samsung patches wouldn't be too voluminous this
cycle?

If you're OK with it, can we proceed to use you as Samsung patch
collection point for this kernel cycle from this moment on?

Yours,
Linus Walleij

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2 4/4] pinctrl: samsung: Use devres version of  gpiochip_add_data Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-20 19:50 +0100
  Re: [PATCH v2 4/4] pinctrl: samsung: Use devres version of gpiochip_add_data Linus Walleij <linus.walleij@linaro.org> - 2017-03-23 10:50 +0100
    Re: [PATCH v2 4/4] pinctrl: samsung: Use devres version of gpiochip_add_data Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-23 12:40 +0100

csiph-web