[tip:x86/mm] x86/efi/32: Fix EFI on systems where the per-cpu GDT is virtually mapped

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	tip-bot for Andy Lutomirski <tipbot@zytor.com>
Newsgroups	linux.kernel
Subject	[tip:x86/mm] x86/efi/32: Fix EFI on systems where the per-cpu GDT is virtually mapped
Date	Thu, 23 Mar 2017 10:30:02 +0100
Message-ID	<to7ea-eW-11@gated-at.bofh.it> (permalink)
References	<tnW93-v1-23@gated-at.bofh.it>
Reply-To	linux-kernel@vger.kernel.org, mingo@kernel.org, boris.ostrovsky@oracle.com, luto@kernel.org, tglx@linutronix.de, hpa@zytor.com, matt@codeblueprint.co.uk, jgross@suse.com, dvlasenk@redhat.com, ard.biesheuvel@linaro.org, torvalds@linux-foundation.org, brgerst@gmail.com, peterz@infradead.org, bp@alien8.de, thgarnie@google.com, jpoimboe@redhat.com
Git-Commit-ID	3fa1cabbc3b61224ef33d3ca4a1a96998529bc68
X-Mailer	tip-git-log-daemon
Robot-ID	<tip-bot.git.kernel.org>
Robot-Unsubscribe	Contact <mailto:hpa@kernel.org> to get blacklisted from these emails
MIME-Version	1.0
Content-Transfer-Encoding	8bit
Content-Type	text/plain; charset=UTF-8
Content-Disposition	inline
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	46
Organization	linux.* mail to news gateway
X-Original-Cc	brgerst@gmail.com, torvalds@linux-foundation.org, ard.biesheuvel@linaro.org, dvlasenk@redhat.com, jpoimboe@redhat.com, bp@alien8.de, thgarnie@google.com, peterz@infradead.org, matt@codeblueprint.co.uk, hpa@zytor.com, luto@kernel.org, tglx@linutronix.de, boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org, mingo@kernel.org, jgross@suse.com
X-Original-Date	Thu, 23 Mar 2017 02:14:09 -0700
X-Original-Message-ID	<tip-3fa1cabbc3b61224ef33d3ca4a1a96998529bc68@git.kernel.org>
X-Original-References	<5ba1d3ffca85e1a5b3ac99265ebe55df4cf0dbe4.1490218061.git.luto@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1607289

Show key headers only | View raw

Commit-ID:  3fa1cabbc3b61224ef33d3ca4a1a96998529bc68
Gitweb:     http://git.kernel.org/tip/3fa1cabbc3b61224ef33d3ca4a1a96998529bc68
Author:     Andy Lutomirski <luto@kernel.org>
AuthorDate: Wed, 22 Mar 2017 14:32:31 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 23 Mar 2017 08:25:07 +0100

x86/efi/32: Fix EFI on systems where the per-cpu GDT is virtually mapped

__pa() on a per-cpu pointer is invalid.  This bug appears to go *waaay*
back, and I guess it's just never been triggered.

Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Garnier <thgarnie@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/5ba1d3ffca85e1a5b3ac99265ebe55df4cf0dbe4.1490218061.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/platform/efi/efi_32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/platform/efi/efi_32.c b/arch/x86/platform/efi/efi_32.c
index 9500711..3481268 100644
--- a/arch/x86/platform/efi/efi_32.c
+++ b/arch/x86/platform/efi/efi_32.c
@@ -68,7 +68,7 @@ pgd_t * __init efi_call_phys_prolog(void)
 	load_cr3(initial_page_table);
 	__flush_tlb_all();
 
-	gdt_descr.address = __pa(get_cpu_gdt_rw(0));
+	gdt_descr.address = get_cpu_gdt_paddr(0);
 	gdt_descr.size = GDT_SIZE - 1;
 	load_gdt(&gdt_descr);

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/7] x86/efi/32: Fix EFI on systems where the percpu GDT is virtually mapped Andy Lutomirski <luto@kernel.org> - 2017-03-22 22:40 +0100
  [tip:x86/mm] x86/efi/32: Fix EFI on systems where the per-cpu GDT  is virtually mapped tip-bot for Andy Lutomirski <tipbot@zytor.com> - 2017-03-23 10:30 +0100

csiph-web