Re: [PATCH v12 6/9] mmc: cavium: Add MMC PCI driver for ThunderX SOCs

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v12 6/9] mmc: cavium: Add MMC PCI driver for ThunderX SOCs
Date	Thu, 23 Mar 2017 10:30:01 +0100
Message-ID	<to7e9-eW-3@gated-at.bofh.it> (permalink)
References	<tjsMh-4Ar-9@gated-at.bofh.it> <tjsMk-4Ar-85@gated-at.bofh.it> <tm1FU-8kN-37@gated-at.bofh.it> <to7e9-eW-5@gated-at.bofh.it>
X-Original-To	Jan Glauber <jan.glauber@caviumnetworks.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hA99UayPtttkqi0/aI3no9czKV72xpq1Ep0czE2Hs80=; b=dpm49NgJFweNy7VkX2YV3DqP3vuwIaU+djHC99rEUJ5Pi80XvT7E8SIGm8E3sAl2ia VEXu8THKJ+Rz19PdZsC/GP3YrA2aOndLmabavkPzBMtZjnhlq6ns2EeV0HKxTGF8M14m AAe2Q/wkzRXJ+YREp3gA982GgLkS3qbpgf12o=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hA99UayPtttkqi0/aI3no9czKV72xpq1Ep0czE2Hs80=; b=PquYZSymJ1ASsoNV2PWx3tnaYYjKePR6JugbN1b0iOhAC4LqeOJnNGzL9XxYu3kOl3 0KLy7k5Rd8Sl1aCb6YeEanV1iORmBQvrAywLgfzjvx3Qr03c4cd/q3uCulGFTbsIsPms 2hk+8sr/0Os2qq3ra5fpXiaAgrxCRulf14kfj7NLj6DGlHlCrEViFzJUDe5av4IUN06r bIgl+5+yPBvoBFEhkO58pu0HSuFw9KRuYcir+QSYvS5tvax9as9QCHbTebwAkP3zZpEH qH7QKlnVddZHpOSng3bXmVxE0ayR5epCEtvEe93PDeKoG/v8PwH+/Y8lHEqndc6Fxcqt RN7w==
X-Gm-Message-State	AFeK/H3VB0LJzisArY0fK/BpTrcLRokjTwzdjWifebk1zvQnsywW2Z4cBlEPtJDtwCqHMdW+kIzSQH8iz6q/ve14
X-Received	by 10.31.92.69 with SMTP id q66mr619909vkb.119.1490261325320; Thu, 23 Mar 2017 02:28:45 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	67
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, David Daney <ddaney@caviumnetworks.com>, "Steven J . Hill" <Steven.Hill@cavium.com>
X-Original-Date	Thu, 23 Mar 2017 10:28:44 +0100
X-Original-Message-ID	<CAPDyKFqzpu1GiRCO5cVQ8yOPg-6CVRUFJSWWW5bLmh99vn+38g@mail.gmail.com>
X-Original-References	<20170310132507.32025-1-jglauber@cavium.com> <20170310132507.32025-7-jglauber@cavium.com> <CAPDyKFp2-KOSYy41QCFcqdU_Rzfncea8Q4QvjHSmho+tAMYMKg@mail.gmail.com> <20170323085812.GA2250@hardcore>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1607286

Show key headers only | View raw

On 23 March 2017 at 09:58, Jan Glauber <jan.glauber@caviumnetworks.com> wrote:
> On Fri, Mar 17, 2017 at 03:58:26PM +0100, Ulf Hansson wrote:
>> On 10 March 2017 at 14:25, Jan Glauber <jglauber@cavium.com> wrote:
>> > Add a platform driver for ThunderX ARM SOCs.
>> >
>> > Signed-off-by: Jan Glauber <jglauber@cavium.com>
>> > ---
>> >  drivers/mmc/host/Kconfig               |  10 ++
>> >  drivers/mmc/host/Makefile              |   2 +
>> >  drivers/mmc/host/cavium-mmc.h          |  10 +-
>> >  drivers/mmc/host/cavium-pci-thunderx.c | 198 +++++++++++++++++++++++++++++++++
>> >  4 files changed, 218 insertions(+), 2 deletions(-)
>> >  create mode 100644 drivers/mmc/host/cavium-pci-thunderx.c
>> >
>> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>> > index 68cc811..3983dee 100644
>> > --- a/drivers/mmc/host/Kconfig
>> > +++ b/drivers/mmc/host/Kconfig
>> > @@ -632,6 +632,16 @@ config MMC_CAVIUM_OCTEON
>> >
>> >           If unsure, say N.
>> >
>> > +config MMC_CAVIUM_THUNDERX
>> > +       tristate "Cavium ThunderX SD/MMC Card Interface support"
>> > +       depends on PCI && 64BIT && (ARM64 || COMPILE_TEST)
>> > +       select GPIO_THUNDERX
>>
>> Do you really need to select GPIO_THUNDERX? What is the relationship?
>
> I don't know much about gpio, but in the end despite all these layers
> there must be a gpio set function called doing the writeq on our SOC
> to enable/disable the power gpio, right?
>
> GPIO_THUNDERX implements this gpio set function for Cavium's SOC.

Got it. However using "select" should be avoided.

Please use "depends on GPIOLIB" instead. The select of "GPIO_THUNDERX"
should be done part of the defconfig or via an SoC specifc Kconfig
file.

[...]

>
>> > +                * Create a dummy device per slot and set the node pointer to
>> > +                * the slot. The easiest way to get this is using
>> > +                * of_platform_device_create.
>> > +                */
>> > +               if (!slot_pdev[i])
>> > +                       slot_pdev[i] = of_platform_device_create(child_node, NULL,
>> > +                                                     &pdev->dev);
>>
>> Seems like we should verify that this is a slot node, by checking the
>> compatible, before creating a platform device for it. No?
>
> Not sure I understand you correctly. Before creating the platform device
> I don't have a device for the slot. Looking at functions I could use to
> check the compatible all of these need a device, which I'm just going to
> create. Can you point me to a function I can use here?

if (of_device_is_compatible(child_node, "mmc-slot"))
   ->create device

[...]

Kind regards
Uffe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v12 6/9] mmc: cavium: Add MMC PCI driver for ThunderX SOCs Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-17 16:10 +0100
  Re: [PATCH v12 6/9] mmc: cavium: Add MMC PCI driver for ThunderX SOCs Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-23 10:30 +0100

csiph-web