Re: [PATCH v2 0/2] Fix memory leak in of_pci_get_host_bridge_resources

From	Shawn Lin <shawn.lin@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/2] Fix memory leak in of_pci_get_host_bridge_resources
Date	2017-03-23 10:10 +0100
Message-ID	<to6UO-89-23@gated-at.bofh.it> (permalink)
References	<to68p-7Yi-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Jeffy,

On 2017/3/23 16:12, Jeffy Chen wrote:
> In of_pci_get_host_bridge_resources, we alloced some struct resource
> variables, and they would cause memory leak since no where to free them.
>

Tested-by: Shawn Lin <shawn.lin@rock-chips.com>

> Changes in v2:
> Don't change the resource_list_create_entry's behavior.
>
> Jeffy Chen (2):
>   PCI: return resource_entry in pci_add_resource helpers
>   of/pci: Fix memory leak in of_pci_get_host_bridge_resources
>
>  drivers/of/of_pci.c | 57 +++++++++++++++++++++++------------------------------
>  drivers/pci/bus.c   | 13 +++++++-----
>  include/linux/pci.h |  8 +++++---
>  3 files changed, 38 insertions(+), 40 deletions(-)
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] Fix memory leak in of_pci_get_host_bridge_resources Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-03-23 09:20 +0100
  [PATCH v2 2/2] of/pci: Fix memory leak in of_pci_get_host_bridge_resources Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-03-23 09:20 +0100
    Re: [PATCH v2 2/2] of/pci: Fix memory leak in of_pci_get_host_bridge_resources Rob Herring <robh@kernel.org> - 2017-03-23 23:10 +0100
      Re: [PATCH v2 2/2] of/pci: Fix memory leak in of_pci_get_host_bridge_resources Dmitry Torokhov <dtor@chromium.org> - 2017-03-24 00:00 +0100
        Re: [PATCH v2 2/2] of/pci: Fix memory leak in of_pci_get_host_bridge_resources jeffy <jeffy.chen@rock-chips.com> - 2017-03-24 02:50 +0100
  [PATCH v2 1/2] PCI: return resource_entry in pci_add_resource helpers Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-03-23 09:20 +0100
  Re: [PATCH v2 0/2] Fix memory leak in  of_pci_get_host_bridge_resources Shawn Lin <shawn.lin@rock-chips.com> - 2017-03-23 10:10 +0100

csiph-web