Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1607209

Re: [PATCH] checkpatch: Allow space leading blank lines in email headers

Show all headers | View raw

On Wed, 2017-03-22 at 23:20 -0700, Darren Hart wrote:
> I do have an open question regarding how we're going about testing for the end
> of the header lines. Since we're not just testing for an empty line to separate
> headers and body, there is clearly more going on here - but I'm not sure what it
> is ... so I can't be sure this doesn't have an unintended consequence.
> 
> > +		      $rawline =~ /^(?:commit\b|from\b|[\w-]+:)/i)) {
> 
> This appears to be an unrelated change, introducing the non-capturing-group
> (?:) and dropping the superfluous .*$ postfix. Did I get that right?

Exactly right.

The capturing of the initial bit of the match and
testing of the rest of the line is simply unnecessary.

I frequently make localized changes like that when I
notice them.  It's not a problem.

cheers, Joe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] checkpatch: Allow space leading blank lines in email  headers Darren Hart <dvhart@infradead.org> - 2017-03-23 08:50 +0100
  Re: [PATCH] checkpatch: Allow space leading blank lines in email  headers Joe Perches <joe@perches.com> - 2017-03-23 08:50 +0100
    Re: [PATCH] checkpatch: Allow space leading blank lines in email  headers Darren Hart <dvhart@infradead.org> - 2017-03-23 17:00 +0100

csiph-web