Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1607172

Re: [PATCH v2] cpufreq: schedutil: Trace frequency only if it has changed

Show all headers | View raw

On 22-03-17, 18:32, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> sugov_update_commit() calls trace_cpu_frequency() to record the
> current CPU frequency if it has not changed in the fast switch case
> to prevent utilities from getting confused (they may report that the
> CPU is idle if the frequency has not been recorded for too long, for
> example).
> 
> However, that may cause the tracepoint to be triggered quite often
> for no real reason (if the frequency doesn't change, we will not
> modify the last update time stamp and governor computations may
> run again shortly when that happens), so don't do that (arguably, it
> is done to work around a utilities bug anyway).
> 
> That allows code duplication in sugov_update_commit() to be reduced
> somewhat too.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> 
> -> v2:
> Drop the trace_cpu_frequency() call in the sg_policy->next_freq == next_freq case.
> 
> ---
>  kernel/sched/cpufreq_schedutil.c |   16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: schedutil: Always trace frequency if it does not change "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-22 02:10 +0100
  Re: [PATCH] cpufreq: schedutil: Always trace frequency if it does  not change Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-22 05:20 +0100
  Re: [PATCH] cpufreq: schedutil: Always trace frequency if it does  not change Peter Zijlstra <peterz@infradead.org> - 2017-03-22 10:40 +0100
    Re: [PATCH] cpufreq: schedutil: Always trace frequency if it does  not change Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-22 11:30 +0100
    Re: [PATCH] cpufreq: schedutil: Always trace frequency if it does not change "Rafael J. Wysocki" <rafael@kernel.org> - 2017-03-22 14:00 +0100
      Re: [PATCH] cpufreq: schedutil: Always trace frequency if it does not change "Rafael J. Wysocki" <rafael@kernel.org> - 2017-03-22 15:20 +0100
      Re: [PATCH] cpufreq: schedutil: Always trace frequency if it does  not change Peter Zijlstra <peterz@infradead.org> - 2017-03-22 15:30 +0100
        Re: [PATCH] cpufreq: schedutil: Always trace frequency if it does not change "Rafael J. Wysocki" <rafael@kernel.org> - 2017-03-22 18:20 +0100
  [PATCH v2] cpufreq: schedutil: Trace frequency only if it has changed "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-22 18:40 +0100
    Re: [PATCH v2] cpufreq: schedutil: Trace frequency only if it has  changed Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-23 05:40 +0100

csiph-web