Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1607134
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: stmmac: dwmac-rk: Add handling for RGMII_ID/RXID/TXID |
| Date | 2017-03-23 03:40 +0100 |
| Message-ID | <to0Pn-41N-1@gated-at.bofh.it> (permalink) |
| References | <tnQQ2-4OP-41@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Wadim Egorov <w.egorov@phytec.de>
Date: Wed, 22 Mar 2017 16:50:22 +0100
> @@ -74,6 +74,10 @@ struct rk_priv_data {
> #define GRF_BIT(nr) (BIT(nr) | BIT(nr+16))
> #define GRF_CLR_BIT(nr) (BIT(nr+16))
>
> +#define DELAY_ENABLE(soc, tx, rx) \
> + ((tx) ? soc##_GMAC_TXCLK_DLY_ENABLE : soc##_GMAC_TXCLK_DLY_DISABLE | \
> + (rx) ? soc##_GMAC_RXCLK_DLY_ENABLE : soc##_GMAC_RXCLK_DLY_DISABLE)
This doesn't evaluate the way you want it to.
You need to put parenthesis around both "x ? a : b" expressions.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] net: stmmac: dwmac-rk: Add handling for RGMII_ID/RXID/TXID Wadim Egorov <w.egorov@phytec.de> - 2017-03-22 17:00 +0100 Re: [PATCH] net: stmmac: dwmac-rk: Add handling for RGMII_ID/RXID/TXID David Miller <davem@davemloft.net> - 2017-03-23 03:40 +0100
csiph-web