Re: [PATCH 2/2] netfilter: ipvs: Compress return logic

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] netfilter: ipvs: Compress return logic
Date	2017-03-21 17:00 +0100
Message-ID	<tnumu-5mU-15@gated-at.bofh.it> (permalink)
References	<tns1j-3SO-3@gated-at.bofh.it> <tns1j-3SO-1@gated-at.bofh.it>
Organization	Cogent Embedded

Show all headers | View raw

Hello!

On 03/21/2017 04:23 PM, simran singhal wrote:

> Simplify function returns by merging assignment and return into
> one command line.

    You mean "one statement"?

> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>
>  --This is my contribution to the netfilter project of
>    Outreachy Round 14.
>
>  net/netfilter/ipvs/ip_vs_ftp.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c
> index d30c327..c93c937 100644
> --- a/net/netfilter/ipvs/ip_vs_ftp.c
> +++ b/net/netfilter/ipvs/ip_vs_ftp.c
> @@ -482,11 +482,8 @@ static struct pernet_operations ip_vs_ftp_ops = {
>
>  static int __init ip_vs_ftp_init(void)
>  {
> -	int rv;
> -
> -	rv = register_pernet_subsys(&ip_vs_ftp_ops);
>  	/* rcu_barrier() is called by netns on error */
> -	return rv;
> +	return register_pernet_subsys(&ip_vs_ftp_ops);
>  }
>
>  /*

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] netfilter: ipvs: Compress return logic simran singhal <singhalsimran0@gmail.com> - 2017-03-21 14:30 +0100
  Re: [PATCH 2/2] netfilter: ipvs: Compress return logic Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-21 17:00 +0100

csiph-web