Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1605614

Re: [PATCH v2] HID: clamp input to logical range if no null state

Show all headers | View raw

On Tue, 14 Mar 2017, Tomasz Kramkowski wrote:

> This patch fixes an issue in drivers/hid/hid-input.c where values
> outside of the logical range are not clamped when "null state" bit of
> the input control is not set.
> 
> This was discussed on the lists [1] and this change stems from the fact
> due to the ambiguity of the HID specification it might be appropriate to
> follow Microsoft's own interpretation of the specification. As noted in
> Microsoft's documentation [2] in the section titled "Required HID usages
> for digitizers" it is noted that values reported outside the logical
> range "will be considered as invalid data and the value will be changed
> to the nearest boundary value (logical min/max)."
> 
> This patch fixes an issue where the (1292:4745) Innomedia INNEX
> GENESIS/ATARI reports out of range values for its X and Y axis of the
> DPad which, due to the null state bit being unset, are forwarded to
> userspace as is. Now these values will get clamped to the logical range
> before being forwarded to userspace. This device was also used to test
> this patch.
> 
> This patch expands on commit 3f3752705dbd ("HID: reject input outside
> logical range only if null state is set").
> 
> Signed-off-by: Tomasz Kramkowski <tk@the-tk.com>
> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

I've added the forgotten references and applied to 
for-4.12/hid-core-null-state-handling. Thanks,

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] HID: clamp input to logical range if no null state Tomasz Kramkowski <tk@the-tk.com> - 2017-03-14 14:40 +0100
  Re: [PATCH v2] HID: clamp input to logical range if no null state Tomasz Kramkowski <tk@the-tk.com> - 2017-03-14 14:50 +0100
  Re: [PATCH v2] HID: clamp input to logical range if no null state Jiri Kosina <jikos@kernel.org> - 2017-03-21 15:00 +0100

csiph-web