Re: [PATCH 3/5] perf/sdt/x86: Move OP parser to tools/perf/arch/x86/

From	Arnaldo Carvalho de Melo <acme@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] perf/sdt/x86: Move OP parser to tools/perf/arch/x86/
Date	2017-03-21 15:20 +0100
Message-ID	<tnsNH-4r2-1@gated-at.bofh.it> (permalink)
References	<sO5sB-7Vh-21@gated-at.bofh.it> <t6nAJ-3eT-3@gated-at.bofh.it> <t6nAJ-3eT-11@gated-at.bofh.it> <t84tY-5Bi-7@gated-at.bofh.it> <t86vM-6Us-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Tue, Feb 07, 2017 at 10:52:17AM +0530, Ravi Bangoria escreveu:
> Thanks Masami for the review.
> 
> On Tuesday 07 February 2017 08:41 AM, Masami Hiramatsu wrote:
> > On Thu,  2 Feb 2017 16:41:41 +0530
> > Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
> >
> >> SDT marker argument is in N@OP format. N is the size of argument and
> >> OP is the actual assembly operand. OP is arch dependent component and
> >> hence it's parsing logic also should be placed under tools/perf/arch/.
> >>
> > Ok, I have one question. Is there any possibility that N is different
> > size of OP? e.g. 8@dil, in this case we will record whole rdi.
> > is that OK?
> 
> By looking at list of markers on my x86 Fedora25 box, yes, it's possible
> for case when register size used in OP is more than size specified by N.
> For example, -4@68(%rbx). But I don't see any argument which specifies
> higher size in N compared to size of register in OP, like you mentioned
> in your example.

Masami, can I have your Acked-by for 3-5/5 in this series?

- Arnaldo

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/5] perf/sdt/x86: Move OP parser to tools/perf/arch/x86/ Arnaldo Carvalho de Melo <acme@redhat.com> - 2017-03-21 15:20 +0100
  Re: [PATCH 3/5] perf/sdt/x86: Move OP parser to  tools/perf/arch/x86/ Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-22 00:20 +0100
    Re: [PATCH 3/5] perf/sdt/x86: Move OP parser to tools/perf/arch/x86/ Arnaldo Carvalho de Melo <acme@redhat.com> - 2017-03-22 12:30 +0100

csiph-web