Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1605552
| From | Chao Yu <yuchao0@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/2] f2fs: fix recording invalid last_victim |
| Date | 2017-03-21 13:20 +0100 |
| Message-ID | <tnqVA-3d4-7@gated-at.bofh.it> (permalink) |
| References | <tnqVA-3d4-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
When doing garbage collection, we try to record segment offset which locates at next one of last victim, using it as the start offset in next searching. But in some corner cases, recorded offset may cross the end of main segment area, it will cause incorrectly searching in dirty_segmap bitmap. This patch adds modular operation to avoid this issue. Reported-by: Yunlei He <heyunlei@huawei.com> Signed-off-by: Chao Yu <yuchao0@huawei.com> --- fs/f2fs/gc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 418fd9881646..939be88a8833 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -361,6 +361,7 @@ static int get_victim_by_default(struct f2fs_sb_info *sbi, sbi->last_victim[p.gc_mode] = last_victim + 1; else sbi->last_victim[p.gc_mode] = segno + 1; + sbi->last_victim[p.gc_mode] %= MAIN_SEGS(sbi); break; } } -- 2.8.2.295.g3f1c1d0
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 2/2] f2fs: fix recording invalid last_victim Chao Yu <yuchao0@huawei.com> - 2017-03-21 13:20 +0100
csiph-web