Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1605492

Re: [PATCH] soc/tegra: pmc: Don't allocate struct tegra_powergate on stack

From Jon Hunter <jonathanh@nvidia.com>
Newsgroups linux.kernel
Subject Re: [PATCH] soc/tegra: pmc: Don't allocate struct tegra_powergate on stack
Date 2017-03-21 11:40 +0100
Message-ID <tnpmO-24D-9@gated-at.bofh.it> (permalink)
References <tnkGt-7kb-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 21/03/17 05:24, Viresh Kumar wrote:
> The size of the struct tegra_powergate is quite big and if any more
> fields are added to the internal genpd structure, following warnings are
> thrown:
> 
> drivers/soc/tegra/pmc.c:577:1: warning: the frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=]

Hmmm ... AFAICT the size of the tegra_powergate struct is 312 bytes
(based upon next-20170321) and so it looks like something massive needs
to be added to the genpd struct to blow this up to over 1024 bytes. Are
there some genpd changes in-flight that are causing this?

Cheers
Jon

-- 
nvpublic

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] soc/tegra: pmc: Don't allocate struct tegra_powergate on stack Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-21 06:40 +0100
  Re: [PATCH] soc/tegra: pmc: Don't allocate struct tegra_powergate on  stack Jon Hunter <jonathanh@nvidia.com> - 2017-03-21 11:40 +0100
    Re: [PATCH] soc/tegra: pmc: Don't allocate struct tegra_powergate on  stack Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-21 11:50 +0100

csiph-web