Re: [Intel-gfx] [PATCH 2/3] drm/i915: split out check for noncontiguous pfn range

From	Chris Wilson <chris@chris-wilson.co.uk>
Newsgroups	linux.kernel
Subject	Re: [Intel-gfx] [PATCH 2/3] drm/i915: split out check for noncontiguous pfn range
Date	2017-03-21 11:30 +0100
Message-ID	<tnpd8-20s-23@gated-at.bofh.it> (permalink)
References	<tn26R-2MC-7@gated-at.bofh.it> <tn26R-2MC-17@gated-at.bofh.it> <tnp3r-1Vs-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 21, 2017 at 09:56:52AM +0000, Chris Wilson wrote:
> On Mon, Mar 20, 2017 at 10:40:28AM +0100, Arnd Bergmann wrote:
> > We get a warning with gcc-7 about a pointless comparison when
> > using a linear memmap:
> > 
> > drivers/gpu/drm/i915/selftests/scatterlist.c: In function 'alloc_table':
> > drivers/gpu/drm/i915/selftests/scatterlist.c:219:66: error: self-comparison always evaluates to false [-Werror=tautological-compare]
> > 
> > Splitting out the comparison into a separate function avoids the warning
> > and makes it slightly more obvious what happens.
> 
> I worried whether gcc will simply get smarter and apply its warning more
> consistently, but I agree the helper is good documentation.
>  
> > Fixes: 935a2f776aa5 ("drm/i915: Add some selftests for sg_table manipulation")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

And applied.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] drm/i915: split out check for noncontiguous pfn range Arnd Bergmann <arnd@arndb.de> - 2017-03-20 10:50 +0100
  Re: [PATCH 2/3] drm/i915: split out check for noncontiguous pfn range Chris Wilson <chris@chris-wilson.co.uk> - 2017-03-21 11:20 +0100
    Re: [Intel-gfx] [PATCH 2/3] drm/i915: split out check for  noncontiguous pfn range Chris Wilson <chris@chris-wilson.co.uk> - 2017-03-21 11:30 +0100

csiph-web