Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1605402

[PATCH 1/7] staging: speakup: Moved logical to previous line.

Path csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Arushi Singhal <arushisinghal19971997@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 1/7] staging: speakup: Moved logical to previous line.
Date Tue, 21 Mar 2017 09:20:01 +0100
Message-ID <tnnbj-Bl-9@gated-at.bofh.it> (permalink)
References <tnnbj-Bl-3@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6KlFFnooldTahkaqdMTEFxD1+IDnrjmm2Oubb7KNTns=; b=uRCeDIfjlOe1mCg/UusGYLHBcPsOVh3knKono1NKu5IjIjMM1pGw4Aj5t/SbdBPBG8 Oclo75z+Ti4UVz/UpBTuS+HVECkUmjf0HlWksLTa3/6EcXfD8jd+tO6a0RyNG0M3lRbU M2A9ffxmIDW0erOv5maxH3xzqLWPK4t0IM3fTCRlBDZK+8ldRT6ZGYwMqW+xpOIKOXSA VRz4eo/wB/n7/9wkfazr//XYF8EYD4s1nCks4NnUOvBUHhhri4GsHTJhtYhzlDtJVOI2 tETxGyHrlWHXUdNAPfDosSAlAclT3YJZg75DX3xwX7+l4QPk4+0Gr1qLsiNZW0b/nOY1 1LNQ==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6KlFFnooldTahkaqdMTEFxD1+IDnrjmm2Oubb7KNTns=; b=I1QDqEKSWxwhT63l3sKigpzyYD60pCUadKTqnm4beHMjueRdoJzl+uh3aXSUz9qFSY 0G6ABU0neg734zouXP3kC8x+4n5Uhvn2g58XcwMv5dtHFWRhSJRZPf967lVLFYOGE6/2 sO6bPPA4ApWdVTn9IkbbLzBVeQKAMGOcu3vui9zaEcDn1n7qsw3GCJ2CF1FrIjNHTiaL w7N+I1CL3WwxBEI7dX3/bGPic4VqKk5bHBaRAi0HQmeP5bIDuS5U+ix2UTpsw8K4Qyuw FzmBAqgAr+FQL0bT8Hz02E2IgkiRMEASLtRkTyJgKFNz2UlqJdfiQqF/cQK4v9RTGByS 6z0w==
X-Gm-Message-State AFeK/H1mzaaPkoLe2oUBWokoEUbQ7zsRY1ZYjfDpUthwMOcsn2hCiUI/zly6XnRRkGu26A==
X-Received by 10.98.56.2 with SMTP id f2mr38957704pfa.130.1490083944344; Tue, 21 Mar 2017 01:12:24 -0700 (PDT)
X-Mailer git-send-email 2.11.0
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 49
Organization linux.* mail to news gateway
X-Original-Cc chris@the-brannons.com, outreachy-kernel@googlegroups.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Arushi Singhal <arushisinghal19971997@gmail.com>
X-Original-Date Tue, 21 Mar 2017 13:42:08 +0530
X-Original-Message-ID <20170321081214.25231-2-arushisinghal19971997@gmail.com>
X-Original-References <20170321081214.25231-1-arushisinghal19971997@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1605402

Show key headers only | View raw


Moved logical AND operators to previous line to fix the following
checkpatch issue:

CHECK: Logical continuations should be on the previous line.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 drivers/staging/speakup/main.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index f280e22d7e15..f71206878363 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -905,8 +905,8 @@ static int get_sentence_buf(struct vc_data *vc, int read_punc)
 	while (start < end) {
 		sentbuf[bn][i] = get_char(vc, (u_short *)start, &tmp);
 		if (i > 0) {
-			if (sentbuf[bn][i] == SPACE && sentbuf[bn][i - 1] == '.'
-			    && numsentences[bn] < 9) {
+			if (sentbuf[bn][i] == SPACE && sentbuf[bn][i - 1] == '.' &&
+			    numsentences[bn] < 9) {
 				/* Sentence Marker */
 				numsentences[bn]++;
 				sentmarks[bn][numsentences[bn]] =
@@ -1292,8 +1292,8 @@ void spk_reset_default_chars(void)
 
 	/* First, free any non-default */
 	for (i = 0; i < 256; i++) {
-		if ((spk_characters[i] != NULL)
-		    && (spk_characters[i] != spk_default_chars[i]))
+		if (spk_characters[i] &&
+		    (spk_characters[i] != spk_default_chars[i]))
 			kfree(spk_characters[i]);
 	}
 
@@ -2088,8 +2088,8 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym,
 	tty = vc->port.tty;
 	if (type >= 0xf0)
 		type -= 0xf0;
-	if (type == KT_PAD
-		&& (vt_get_leds(fg_console, VC_NUMLOCK))) {
+	if (type == KT_PAD &&
+	    (vt_get_leds(fg_console, VC_NUMLOCK))) {
 		if (up_flag) {
 			spk_keydown = 0;
 			goto out;
-- 
2.11.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 1/7] staging: speakup: Moved logical to previous line. Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-21 09:20 +0100

csiph-web