Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1605440

Re: [PATCH v12 4/9] mmc: cavium: Work-around hardware bug on cn6xxx and cnf7xxx

Path csiph.com!feeder.erje.net!2.eu.feeder.erje.net!news.szaf.org!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH v12 4/9] mmc: cavium: Work-around hardware bug on cn6xxx and cnf7xxx
Date Tue, 21 Mar 2017 10:00:02 +0100
Message-ID <tnnO2-Sm-11@gated-at.bofh.it> (permalink)
References <tjsMh-4Ar-9@gated-at.bofh.it> <tjsMi-4Ar-35@gated-at.bofh.it> <tm13b-7Il-9@gated-at.bofh.it> <tnnO2-Sm-13@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=gZNKOyydWBEXx0nyIXaXzOKvHxYjwGHxOK/xcrb+qGE=; b=kJnWM0zGiIcBgooT4qqaESWDiN9ycud6gbkt5Q0VFwg31ISa8WLZvIH+USAwZDIgVT 7z8A66Ls2i6EaWJ2q+h7KiEbxej9j47f+S9mdxXAqjJMVQsNbuKhc0tme3ggJgRFm5Cv QfTYYHLxr1bzFwNrGeaTAMUqUIyg8p1ySlqlIPLIKyBFIrqgTnlShacdK6PvX7CvmU0l TVXRi0Qlf64FeZnDZNfU74GOPn/03j0p9WsCHTD0JglHZYbphNtuUfsfIKJJhhREV6YM eMzs8jxKfXJZV+CAl+2WbJ9xTKHzJ4xdNENOwz1ugfLRuaZgmE09A8lVuTwAvUNcRcT8 5Mdw==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=gZNKOyydWBEXx0nyIXaXzOKvHxYjwGHxOK/xcrb+qGE=; b=PSyjeSpCsYOdTZOSrju4+Z3fddeybmY70PsyGXGesvk1Cl3C0cb8A5/m94f+2QMKPV CYWQRpAbM5y3A2fhArMVOV/ed/kRTQzc3/fE/nqjmqO1FB3NSEEnbm0vdI0Cx9jfnoHN v7ZEGb6mSGoa3jXU2DDqotsHHnvzwIUQTndUepCkivKf/QghiLModHybIgcHPyQJVs2K S5UaHxAPQU5aZja0yN0D9gqbkBu7VNlopubdXoT7BzYPnTJtM+lgks6C7r6/gCwprtlb XoVcxToo/Xu6zCuxFEoAP50tCg6BTySswBGfDBr2JINhngYQDGT4l9Yji9ZiFm1wo2pZ 0a1g==
X-Gm-Message-State AFeK/H3YU0SvAO+1oPBH6fx/rJ6wPdIYpF6bNTiPGZKvrHCeglo1usI2AIbnHT+lRtIFyQs9Pjg7ydX7svr2jA==
X-Received by 10.157.40.149 with SMTP id s21mr19279389ota.226.1490086705244; Tue, 21 Mar 2017 01:58:25 -0700 (PDT)
MIME-Version 1.0
X-Google-Sender-Auth EFUcdcoUp2oa1CTDYBKG7mPxJic
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 16
Organization linux.* mail to news gateway
X-Original-Cc Ulf Hansson <ulf.hansson@linaro.org>, Jan Glauber <jglauber@cavium.com>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Steven J . Hill" <Steven.Hill@cavium.com>, David Daney <david.daney@cavium.com>
X-Original-Date Tue, 21 Mar 2017 09:58:24 +0100
X-Original-Message-ID <CAK8P3a2BX3-hbgGzYD_Oub1MR1pC9kLq73L+9gR5_gvYQyqqXA@mail.gmail.com>
X-Original-References <20170310132507.32025-1-jglauber@cavium.com> <20170310132507.32025-5-jglauber@cavium.com> <CAPDyKFrbAUoYk7h8XmYdwiyr8QZXA0WTyFVw3EVFQ8UK71cwOw@mail.gmail.com> <6dc8a2a3-ca79-745a-c716-2188319b9378@caviumnetworks.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1605440

Show key headers only | View raw


On Mon, Mar 20, 2017 at 9:45 PM, David Daney <ddaney@caviumnetworks.com> wrote:
> On 03/17/2017 07:13 AM, Ulf Hansson wrote:
>> My point is really that we should avoid exporting SoC specific APIs
>> which shall be called from drivers. This is old fashion.
>
>
> Some people find it objectionable to see 1-off architecture specific in-line
> asm in a driver file, but I agree that putting it as close to the user as
> possible makes sense.

The proper solution might be to create an architecture independent interface
for it, what it is that the function does. Can you explain what the purpose
of locking/unlocking the cache line for MMC is? Is this something that
could be done more generally in the dma_map_ops implementation?

     Arnd

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v12 4/9] mmc: cavium: Work-around hardware bug on cn6xxx  and cnf7xxx Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-17 15:30 +0100
  Re: [PATCH v12 4/9] mmc: cavium: Work-around hardware bug on cn6xxx  and cnf7xxx Arnd Bergmann <arnd@arndb.de> - 2017-03-20 22:50 +0100
  Re: [PATCH v12 4/9] mmc: cavium: Work-around hardware bug on cn6xxx  and cnf7xxx Arnd Bergmann <arnd@arndb.de> - 2017-03-21 10:00 +0100
    Re: [PATCH v12 4/9] mmc: cavium: Work-around hardware bug on cn6xxx  and cnf7xxx Arnd Bergmann <arnd@arndb.de> - 2017-03-21 20:50 +0100

csiph-web