Re: [PATCH 1/2] [media] vcodec: mediatek: add missing linux/slab.h include

From	Rick Chang <rick.chang@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] [media] vcodec: mediatek: add missing linux/slab.h include
Date	2017-03-21 02:30 +0100
Message-ID	<tngMx-4Et-7@gated-at.bofh.it> (permalink)
References	<tn2gz-2R9-51@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arnd,

Thank you for the patch, but someone has fixed the same problem.

Regards,
Rick

On Mon, 2017-03-20 at 10:47 +0100, Arnd Bergmann wrote:
> With the newly added driver, I have run into randconfig failures like:
> 
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function 'mtk_jpeg_open':
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:8: error: implicit declaration of function 'kzalloc';did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
> 
> Including the header with the declaration solves the problem.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> index b10183f7942b..f9bd58ce7d32 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -22,6 +22,7 @@
>  #include <linux/of_platform.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
> +#include <linux/slab.h>
>  #include <linux/spinlock.h>
>  #include <media/v4l2-event.h>
>  #include <media/v4l2-mem2mem.h>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] [media] vcodec: mediatek: add missing linux/slab.h include Arnd Bergmann <arnd@arndb.de> - 2017-03-20 11:00 +0100
  [PATCH 2/2] [media] vcodec: mediatek: mark pm functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-03-20 11:00 +0100
    Re: [PATCH 2/2] [media] vcodec: mediatek: mark pm functions as  __maybe_unused Rick Chang <rick.chang@mediatek.com> - 2017-03-21 02:50 +0100
  Re: [PATCH 1/2] [media] vcodec: mediatek: add missing linux/slab.h  include Rick Chang <rick.chang@mediatek.com> - 2017-03-21 02:30 +0100

csiph-web