[PATCH] PCI: rockchip: don't leak the PCI resource list

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Brian Norris <briannorris@chromium.org>
Newsgroups	linux.kernel
Subject	[PATCH] PCI: rockchip: don't leak the PCI resource list
Date	Tue, 21 Mar 2017 00:00:02 +0100
Message-ID	<tnero-2XH-27@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=1ANmi3o6qGrW5i+7YubT5bAsFOcu9UhUOOglsvMJKHo=; b=e2b/KGrhWRkEiLEL1Xct1BPczNKFWsBu0S58BbJRFxmH/W29Ln8MONIIacPUJZdzQB E/GHUUzrSs0Rui8X+wpmk2bv0tK6kfBSOgrFtjxEzQ9a8HN6oUHvP8jeHmg8Z7dIs0e6 RSmU0sFlk8yWTZzRObbrAQVj1o3IH1IbK7OQI=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1ANmi3o6qGrW5i+7YubT5bAsFOcu9UhUOOglsvMJKHo=; b=biuuAeRCoFYcvtp3Ur7yi27NrlAZl8WLYiocayrkcbKZaUTsXvmW7UbUuGo7Xo/kAt Z/wOKLyIsKc31S1/XRD8OGnc889V+qkMzzTeQJdNb5aU7Cw3nAopusCAh1qMa5/LVP0H KThNxfpJg/fQtdpgyHHxUEwDehl1baILZLQo2XKnRcg7ptLEBurgujP2yFgLUNDAyEju IBmCtMg1DEE/TVaFH/lvCgI7Qe0TKp/8bC6M1HO+dXxs2TTRUXnTksR9WhKWfM5yX/iR AtUoHOFgSOqJ1iKpZUBB6H0tnC7X2x6O1T+BzGMM3PKBX9+XTYE7zPEFMbIS/Y5DA0R9 8WIQ==
X-Gm-Message-State	AFeK/H392CpUD4EfOe/jrBFo2wQeEooZA6+8+37Dbf+1l2HBENU5iflOYcfKPpv3/GvMdeXF
X-Received	by 10.84.202.163 with SMTP id x32mr42702797pld.67.1490050190452; Mon, 20 Mar 2017 15:49:50 -0700 (PDT)
X-Mailer	git-send-email 2.12.0.367.g23dc2f6d3c-goog
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	<linux-kernel@vger.kernel.org>, Shawn Lin <shawn.lin@rock-chips.com>, Jeffy Chen <jeffy.chen@rock-chips.com>, Wenrui Li <wenrui.li@rock-chips.com>, linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, Brian Norris <briannorris@chromium.org>
X-Original-Date	Mon, 20 Mar 2017 15:49:36 -0700
X-Original-Message-ID	<20170320224936.28605-1-briannorris@chromium.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1605190

Show key headers only | View raw

This list is local to the probe() function. We should free it up in both
the success case and the error case, but currently we're only freeing it
in the error case (see commit f1d722b607d6 ("PCI: rockchip: Fix
rockchip_pcie_probe() error path to free resource list")).

Caught by kmemleak, when doing repeated bind/unbind tests.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 drivers/pci/host/pcie-rockchip.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
index bd6df7254de4..8087a0698d65 100644
--- a/drivers/pci/host/pcie-rockchip.c
+++ b/drivers/pci/host/pcie-rockchip.c
@@ -1396,6 +1396,7 @@ static int rockchip_pcie_probe(struct platform_device *pdev)
 		goto err_free_res;
 	}
 	rockchip->root_bus = bus;
+	pci_free_resource_list(&res);
 
 	pci_bus_size_bridges(bus);
 	pci_bus_assign_resources(bus);
-- 
2.12.0.367.g23dc2f6d3c-goog

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] PCI: rockchip: don't leak the PCI resource list Brian Norris <briannorris@chromium.org> - 2017-03-21 00:00 +0100
  Re: [PATCH] PCI: rockchip: don't leak the PCI resource list Shawn Lin <shawn.lin@rock-chips.com> - 2017-03-21 02:30 +0100
    Re: [PATCH] PCI: rockchip: don't leak the PCI resource list Brian Norris <briannorris@chromium.org> - 2017-03-21 03:30 +0100
      Re: [PATCH] PCI: rockchip: don't leak the PCI resource list jeffy <jeffy.chen@rock-chips.com> - 2017-03-21 05:00 +0100

csiph-web