Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1605194

Re: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused

From Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups linux.kernel
Subject Re: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused
Date 2017-03-21 00:10 +0100
Message-ID <tneB4-3ga-19@gated-at.bofh.it> (permalink)
References <tn1DQ-2AT-19@gated-at.bofh.it> <tn4s2-4zk-9@gated-at.bofh.it> <tn4BI-4CH-11@gated-at.bofh.it> <tneB4-3ga-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 20, 2017 at 11:01:36PM +0000, Winkler, Tomas wrote:

> I believe that in this case the #ifdefs can be done correctly quite
> easily, but now I'm not against your solution as well, just maybe
> put some of this info to the commit message.

I perfer fewer ifdefs, it makes it more maintainable..

The compiler will remove unused static functions.

Jason

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-03-20 10:20 +0100
  RE: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-03-20 13:20 +0100
    Re: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-03-20 13:30 +0100
      RE: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-03-21 00:10 +0100
        Re: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-03-21 00:10 +0100
          RE: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-03-21 00:40 +0100
            Re: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-03-21 08:40 +0100
  Re: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-22 11:30 +0100

csiph-web