Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1605146

Re: [PATCH] power: bq24190_charger: mark PM functions as __maybe_unused

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Mon, Mar 20, 2017 at 02:14:15PM +0100, Arnd Bergmann wrote:
> Without CONFIG_PM, we get a harmless warning:
> 
> drivers/power/supply/bq24190_charger.c:1514:12: error: 'bq24190_runtime_resume' defined but not used [-Werror=unused-function]
> drivers/power/supply/bq24190_charger.c:1501:12: error: 'bq24190_runtime_suspend' defined but not used [-Werror=unused-function]
> 
> To avoid the warning, we can mark all four PM functions as __maybe_unused,
> which also lets us remove the incorrect #ifdef.
> 
> Fixes: 3d8090cba638 ("power: bq24190_charger: Check the interrupt status on resume")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, queued.

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] power: bq24190_charger: mark PM functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-03-20 14:30 +0100
  Re: [PATCH] power: bq24190_charger: mark PM functions as  __maybe_unused Tony Lindgren <tony@atomide.com> - 2017-03-20 15:50 +0100
  Re: [PATCH] power: bq24190_charger: mark PM functions as __maybe_unused Liam Breck <liam@networkimprov.net> - 2017-03-20 19:40 +0100
  Re: [PATCH] power: bq24190_charger: mark PM functions as  __maybe_unused Sebastian Reichel <sre@kernel.org> - 2017-03-20 22:40 +0100
  Re: [PATCH] power: bq24190_charger: mark PM functions as  __maybe_unused Mark Greer <mgreer@animalcreek.com> - 2017-03-21 05:00 +0100

csiph-web