Re: [net-next PATCH 2/2] tcp: Record Rx hash and NAPI ID in tcp_child_process

From	Eric Dumazet <edumazet@google.com>
Newsgroups	linux.kernel
Subject	Re: [net-next PATCH 2/2] tcp: Record Rx hash and NAPI ID in tcp_child_process
Date	2017-03-20 23:10 +0100
Message-ID	<tndF0-2F7-19@gated-at.bofh.it> (permalink)
References	<tndlD-2eT-5@gated-at.bofh.it> <tndlD-2eT-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 20, 2017 at 2:48 PM, Alexander Duyck
<alexander.duyck@gmail.com> wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> While working on some recent busy poll changes we found that child sockets
> were being instantiated without NAPI ID being set.  In our first attempt to
> fix it, it was suggested that we should just pull programming the NAPI ID
> into the function itself since all callers will need to have it set.
>
> In addition to NAPI ID I have decided to also pull in populating the Rx
> hash since it likely has the same problem as NAPI ID but just doesn't have
> the visibility.

It looks like Rx hash was initialized elsewhere (
tcp_get_cookie_sock() & tcp_check_req())

So this probably could be cleaned up, if done at the proper place ;)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[net-next PATCH 2/2] tcp: Record Rx hash and NAPI ID in  tcp_child_process Alexander Duyck <alexander.duyck@gmail.com> - 2017-03-20 22:50 +0100
  Re: [net-next PATCH 2/2] tcp: Record Rx hash and NAPI ID in tcp_child_process Eric Dumazet <edumazet@google.com> - 2017-03-20 23:10 +0100

csiph-web