Re: [PATCH v3] usb: hub: Fix error loop seen after hub communication errors

From	Doug Anderson <dianders@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] usb: hub: Fix error loop seen after hub communication errors
Date	2017-03-20 19:20 +0100
Message-ID	<tna4p-52-15@gated-at.bofh.it> (permalink)
References	<tlJfY-2Un-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Thu, Mar 16, 2017 at 12:24 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> @@ -1198,7 +1201,7 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type)
>
>         /* Scan all ports that need attention */
>         kick_hub_wq(hub);
> -
> +abort:

One tiny nit that could be done when applying this patch is to add a
space before "abort".  Other goto labels in this function are preceded
by a space and it's sane to try to match the existing coding
convention in the function rather than trying to mix and match.

Other than that this patch seems sane to me, but I am by no means an
expert on this code.  ;)

-Doug

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] usb: hub: Fix error loop seen after hub communication errors Guenter Roeck <linux@roeck-us.net> - 2017-03-16 20:30 +0100
  Re: [PATCH v3] usb: hub: Fix error loop seen after hub communication  errors Alan Stern <stern@rowland.harvard.edu> - 2017-03-17 17:40 +0100
  Re: [PATCH v3] usb: hub: Fix error loop seen after hub communication errors Doug Anderson <dianders@chromium.org> - 2017-03-20 19:20 +0100

csiph-web