RE: [PATCH v7 09/11] scsi: ufs: connect to RPMB subsystem

From	"Winkler, Tomas" <tomas.winkler@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v7 09/11] scsi: ufs: connect to RPMB subsystem
Date	2017-03-22 22:30 +0100
Message-ID	<tnVZn-rc-11@gated-at.bofh.it> (permalink)
References	<sAXjc-74X-3@gated-at.bofh.it> <sAXjd-74X-55@gated-at.bofh.it> <sAXsS-7ns-33@gated-at.bofh.it> <sAXMd-7uI-9@gated-at.bofh.it> <sAZO2-ic-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> 
> On Mon, Nov 07, 2016 at 07:27:38PM +0000, Winkler, Tomas wrote:
> > I  value your opinion but I'm not responsible for inventing RPMB
> > and/or its  implementation storage devices (eMMC, UFC, NVMe), it's pretty
> much done deal out there in the wild.
> > I'm just trying to provide common API above it.

Somehow I've missed that answer, now I got back when search for comments before I'll post a new series.

> And the common API must go through the SCSI midlayer.  

I've actually tried to do  a midlayer, but I found it's too UFS specific, so there is no point to this abstraction.  
As not all needed data are accessible via scsi calls.  The solution I propose fits with what is done in eMMC (emmc specific  IOCTL).
There is already some code that breaks that layering in  ufshcd_set_dev_pwr_mode when talking to the special sdev_ufs.
Maybe I need more hint for the correct directions.

If it can't we won't
> support it, so please drop the UFS patches from the series.

If you have more constructive comments, I'll be glad to hear and address. 

Thanks
Tomas

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [PATCH v7 09/11] scsi: ufs: connect to RPMB subsystem "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-03-22 22:30 +0100

csiph-web