Re: [PATCH 5/6] notifiers: Use CHECK_DATA_CORRUPTION() on checks

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] notifiers: Use CHECK_DATA_CORRUPTION() on checks
Date	2017-03-22 21:00 +0100
Message-ID	<tnUAh-7GG-1@gated-at.bofh.it> (permalink)
References	<ti6kN-4hd-9@gated-at.bofh.it> <ti6kN-4hd-11@gated-at.bofh.it> <tnU7g-7qr-3@gated-at.bofh.it> <tnUgV-7uL-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 22, 2017 at 12:32 PM, Arjan van de Ven
<arjan@linux.intel.com> wrote:
> On 3/22/2017 12:29 PM, Kees Cook wrote:
>>>
>>> When performing notifier function pointer sanity checking, allow
>>> CONFIG_BUG_ON_DATA_CORRUPTION to upgrade from a WARN to a BUG.
>>> Additionally enables CONFIG_DEBUG_NOTIFIERS when selecting
>>> CONFIG_BUG_ON_DATA_CORRUPTION.
>
>
>> Any feedback on this change? By default, this retains the existing
>> WARN behavior...
>
>
> if you're upgrading, is the end point really a panic() ?
> e.g. do you assume people to also set panic-on-oops?

That's one option, yes. With the BUG, the process associated is killed
(which is the first level of defense upgrade), and if a system is also
set to panic-on-oops, the entire system will panic (and usually such
systems also retain their crash consoles in some fashion for later
analysis, etc).

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 5/6] notifiers: Use CHECK_DATA_CORRUPTION() on checks Kees Cook <keescook@chromium.org> - 2017-03-22 20:30 +0100
  Re: [PATCH 5/6] notifiers: Use CHECK_DATA_CORRUPTION() on checks Arjan van de Ven <arjan@linux.intel.com> - 2017-03-22 20:40 +0100
    Re: [PATCH 5/6] notifiers: Use CHECK_DATA_CORRUPTION() on checks Kees Cook <keescook@chromium.org> - 2017-03-22 21:00 +0100

csiph-web